From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD19FC43381 for ; Mon, 1 Apr 2019 09:17:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9BA932086C for ; Mon, 1 Apr 2019 09:17:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vVdAltvI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726388AbfDAJRQ (ORCPT ); Mon, 1 Apr 2019 05:17:16 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:40282 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725817AbfDAJRQ (ORCPT ); Mon, 1 Apr 2019 05:17:16 -0400 Received: by mail-wm1-f68.google.com with SMTP id z24so10511108wmi.5 for ; Mon, 01 Apr 2019 02:17:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=oPbrZRqUIkI47EwtaMkbph3+RLzCt7y1i6s9FUe85S8=; b=vVdAltvIJoyYvshIboJmPydHZdHYHydVdJR835v32LY25jZ36drstn00rxRtWVN/df 8woMN2FKqk21+6eDSbCsje1bSH6n7k16OmUjrwiEKxM7S+Of+Mzx3lknSRxp+cGSXsex xb2MoanKIVi7nflY5GvOpumQAGIweH8aYCfGzLPj1QW2viXQ7ItZCuSVmDhf3Ov/LB9J ZB8UniO1hhZk35WDei+uV70v85BzuBStopdqVhFR+FtamzeX3YQhuh+LbvlI4MPeM/eH NnCd0prSA8OKp1Mz6Y3BUd6pBhXKNgrIC4Lz5BriiIYLEOic+mto0AGanWGgbvjpu9XJ 5DGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oPbrZRqUIkI47EwtaMkbph3+RLzCt7y1i6s9FUe85S8=; b=BM/EIXANbA8eBxD+aVqWKMRTzy30utnRwJT/vLjOVL99ZC4MKFxYXPy00cow576i8N c/7zifTt3OLHf3YG6Xomc6N54o6TjcMYWsX4L9DnPGlYM5RXAoZp168YisXHfi1jV1Ot N1eLNDTPIXXJGFSdL3iCk0h+9wQS/lD6bUkLDmsGON8F6Ph2VIbt1wxTCFQ1Mldon+qy jCXskwBaFe0GE87Za42Itw4Rmx5OmqNqSeQOFboIeTsbnU0iQEOSeItvkVw0jXjIb0NV o3YQD8d6pWmJQ7wuFlG3Zj7ygKAN/abXZQWPrTchXbIhyojy4RpVszdup4l9ef0KQKTi HgLA== X-Gm-Message-State: APjAAAWGD/j/bLXde+M1rgwf8E66hFOpQOoSxkM+hwldwpQ8iJoEiXSM Y6otl2VkfMwj6tRrhhAyjSLYA5zY X-Google-Smtp-Source: APXvYqyHEr5R22z1b4XHV7Ao1eKDZj18w+RcdzSx/MG8TB4sP0KDRH72CB39C+eESkX1K5SpbpI6wQ== X-Received: by 2002:a1c:c018:: with SMTP id q24mr11412635wmf.148.1554110234608; Mon, 01 Apr 2019 02:17:14 -0700 (PDT) Received: from [192.168.8.147] (60.87.136.77.rev.sfr.net. [77.136.87.60]) by smtp.gmail.com with ESMTPSA id w2sm7906248wrm.74.2019.04.01.02.17.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Apr 2019 02:17:13 -0700 (PDT) Subject: Re: [PATCH net-next] r8169: use netif_receive_skb_list batching To: David Miller , hkallweit1@gmail.com Cc: nic_swsd@realtek.com, netdev@vger.kernel.org, brouer@redhat.com, ecree@solarflare.com References: <20190331.111114.1510038068515936853.davem@davemloft.net> From: Eric Dumazet Message-ID: <61e68943-fb2c-ff89-90e6-1d2742c56687@gmail.com> Date: Mon, 1 Apr 2019 02:17:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190331.111114.1510038068515936853.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 03/31/2019 11:11 AM, David Miller wrote: > From: Heiner Kallweit > Date: Sun, 31 Mar 2019 15:18:48 +0200 > >> Use netif_receive_skb_list() instead of napi_gro_receive() to benefit >> from batched skb processing. >> >> Signed-off-by: Heiner Kallweit > > Applied. > This means no GRO at all, and reduced performance in many useful cases.