From: John Fastabend <john.fastabend@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>,
Brendan Jackman <jackmanb@google.com>,
Hou Tao <houtao1@huawei.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Martin KaFai Lau <kafai@fb.com>, Yonghong Song <yhs@fb.com>,
Andrii Nakryiko <andrii@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next] bpf, x86: remove unnecessary handling of BPF_SUB atomic op
Date: Thu, 27 Jan 2022 18:40:39 -0800 [thread overview]
Message-ID: <61f357a749eef_738dc208ec@john.notmuch> (raw)
In-Reply-To: <c0831a45-3d39-891b-b89c-36167421d28b@iogearbox.net>
Daniel Borkmann wrote:
> On 1/27/22 11:48 AM, Brendan Jackman wrote:
> > Yep - BPF_SUB is also excluded in Documentation/networking/filter.rst,
> > plus the interpreter and verifier don't support it.
> >
> > Thanks,
> >
> > Acked-by: Brendan Jackman <jackmanb@google.com>
>
> I was wondering about verifier specifically as well. Added a note to the
> commit log that verifier rejects BPF_SUB while applying, thanks!
>
Thanks for the follow up Hou/Brendan LGTM as well. After its been
merged, but ACK from me as well.
next prev parent reply other threads:[~2022-01-28 2:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 8:32 [PATCH bpf-next] bpf, x86: remove unnecessary handling of BPF_SUB atomic op Hou Tao
2022-01-27 10:48 ` Brendan Jackman
2022-01-27 21:51 ` Daniel Borkmann
2022-01-28 2:40 ` John Fastabend [this message]
2022-01-27 21:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61f357a749eef_738dc208ec@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=houtao1@huawei.com \
--cc=jackmanb@google.com \
--cc=kafai@fb.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).