From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
netdev@vger.kernel.org
Cc: dsa@cumulusnetworks.com, roopa@cumulusnetworks.com,
bridge@lists.linux-foundation.org, mrv@mojatatu.com,
davem@davemloft.net
Subject: Re: [PATCH net-next v4 2/2] bridge: vlan: signal if anything changed on vlan add
Date: Thu, 26 Oct 2017 19:16:27 +0900 [thread overview]
Message-ID: <622bf4ff-e493-58f0-bedf-8183a82e8772@lab.ntt.co.jp> (raw)
In-Reply-To: <1508971954-3567-3-git-send-email-nikolay@cumulusnetworks.com>
On 2017/10/26 7:52, Nikolay Aleksandrov wrote:
...
> @@ -559,6 +574,7 @@ int br_vlan_add(struct net_bridge *br, u16 vid, u16 flags)
>
> ASSERT_RTNL();
>
> + *changed = false;
> vg = br_vlan_group(br);
> vlan = br_vlan_find(vg, vid);
> if (vlan) {
> @@ -576,9 +592,12 @@ int br_vlan_add(struct net_bridge *br, u16 vid, u16 flags)
> refcount_inc(&vlan->refcnt);
> vlan->flags |= BRIDGE_VLAN_INFO_BRENTRY;
> vg->num_vlans++;
> + *changed = true;
> }
> - __vlan_add_flags(vlan, flags);
> - return 0;
> + if (__vlan_add_flags(vlan, flags))
> + *changed = true;
> +
> + return ret;
"ret" isn't always initialized here, is it?
Toshiaki Makita
next prev parent reply other threads:[~2017-10-26 10:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 12:32 [PATCH net-next v2 0/2] bridge: make setlink/dellink notifications more accurate Nikolay Aleksandrov
2017-10-24 12:32 ` [PATCH net-next v2 1/2] bridge: netlink: " Nikolay Aleksandrov
2017-10-24 12:32 ` [PATCH net-next v2 2/2] bridge: vlan: signal if anything changed on vlan add Nikolay Aleksandrov
2017-10-25 20:51 ` kbuild test robot
2017-10-25 21:49 ` [PATCH net-next v2 0/2] bridge: make setlink/dellink notifications more accurate Nikolay Aleksandrov
2017-10-25 21:59 ` [PATCH net-next v3 " Nikolay Aleksandrov
2017-10-25 21:59 ` [PATCH net-next v3 1/2] bridge: netlink: " Nikolay Aleksandrov
2017-10-26 8:17 ` Stephen Hemminger
2017-10-26 8:25 ` Nikolay Aleksandrov
2017-10-25 21:59 ` [PATCH net-next v3 2/2] bridge: vlan: signal if anything changed on vlan add Nikolay Aleksandrov
2017-10-25 22:14 ` [PATCH net-next v3 0/2] bridge: make setlink/dellink notifications more accurate Nikolay Aleksandrov
2017-10-25 22:52 ` [PATCH net-next v4 " Nikolay Aleksandrov
2017-10-25 22:52 ` [PATCH net-next v4 1/2] bridge: netlink: " Nikolay Aleksandrov
2017-10-25 22:52 ` [PATCH net-next v4 2/2] bridge: vlan: signal if anything changed on vlan add Nikolay Aleksandrov
2017-10-26 10:16 ` Toshiaki Makita [this message]
2017-10-26 11:02 ` [Bridge] " Nikolay Aleksandrov
2017-10-26 11:08 ` Nikolay Aleksandrov
2017-10-26 1:12 ` [PATCH net-next v3 0/2] bridge: make setlink/dellink notifications more accurate David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=622bf4ff-e493-58f0-bedf-8183a82e8772@lab.ntt.co.jp \
--to=makita.toshiaki@lab.ntt.co.jp \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox