* [PATCH v2] of: mdio: Add of_node_put() when breaking out of for_each_xx
@ 2022-09-13 12:56 Liang He
2022-09-13 15:13 ` Liang He
2022-09-20 14:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Liang He @ 2022-09-13 12:56 UTC (permalink / raw)
To: windhl, andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni,
netdev, linmq006
In of_mdiobus_register(), we should call of_node_put() for 'child'
escaped out of for_each_available_child_of_node().
Fixes: 66bdede495c7 ("of_mdio: Fix broken PHY IRQ in case of probe deferral")
Cc: Miaoqian Lin <linmq006@gmail.com>
Co-developed-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
v2: use proper tag advised by Jakub Kicinski
v1: fix the bug
drivers/net/mdio/of_mdio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of_mdio.c
index 9e3c815a070f..796e9c7857d0 100644
--- a/drivers/net/mdio/of_mdio.c
+++ b/drivers/net/mdio/of_mdio.c
@@ -231,6 +231,7 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
return 0;
unregister:
+ of_node_put(child);
mdiobus_unregister(mdio);
return rc;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re:[PATCH v2] of: mdio: Add of_node_put() when breaking out of for_each_xx
2022-09-13 12:56 [PATCH v2] of: mdio: Add of_node_put() when breaking out of for_each_xx Liang He
@ 2022-09-13 15:13 ` Liang He
2022-09-15 16:51 ` [PATCH " Miaoqian Lin
2022-09-20 14:50 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Liang He @ 2022-09-13 15:13 UTC (permalink / raw)
To: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni, netdev,
linmq006
At 2022-09-13 20:56:59, "Liang He" <windhl@126.com> wrote:
>In of_mdiobus_register(), we should call of_node_put() for 'child'
>escaped out of for_each_available_child_of_node().
>
>Fixes: 66bdede495c7 ("of_mdio: Fix broken PHY IRQ in case of probe deferral")
>Cc: Miaoqian Lin <linmq006@gmail.com>
>Co-developed-by: Miaoqian Lin <linmq006@gmail.com>
>Signed-off-by: Liang He <windhl@126.com>
>Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Hi, Miaoqian,
this Sob should directly from you,
please do it!
>---
> v2: use proper tag advised by Jakub Kicinski
> v1: fix the bug
>
> drivers/net/mdio/of_mdio.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of_mdio.c
>index 9e3c815a070f..796e9c7857d0 100644
>--- a/drivers/net/mdio/of_mdio.c
>+++ b/drivers/net/mdio/of_mdio.c
>@@ -231,6 +231,7 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
> return 0;
>
> unregister:
>+ of_node_put(child);
> mdiobus_unregister(mdio);
> return rc;
> }
>--
>2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] of: mdio: Add of_node_put() when breaking out of for_each_xx
2022-09-13 15:13 ` Liang He
@ 2022-09-15 16:51 ` Miaoqian Lin
0 siblings, 0 replies; 4+ messages in thread
From: Miaoqian Lin @ 2022-09-15 16:51 UTC (permalink / raw)
To: Liang He; +Cc: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni, netdev
On Tue, Sep 13, 2022 at 11:13:20PM +0800, Liang He wrote:
>
>
>
> At 2022-09-13 20:56:59, "Liang He" <windhl@126.com> wrote:
> >In of_mdiobus_register(), we should call of_node_put() for 'child'
> >escaped out of for_each_available_child_of_node().
> >
> >Fixes: 66bdede495c7 ("of_mdio: Fix broken PHY IRQ in case of probe deferral")
> >Cc: Miaoqian Lin <linmq006@gmail.com>
> >Co-developed-by: Miaoqian Lin <linmq006@gmail.com>
> >Signed-off-by: Liang He <windhl@126.com>
> >Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
>
> Hi, Miaoqian,
> this Sob should directly from you,
> please do it!
>
>
> >---
> > v2: use proper tag advised by Jakub Kicinski
> > v1: fix the bug
> >
> > drivers/net/mdio/of_mdio.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of_mdio.c
> >index 9e3c815a070f..796e9c7857d0 100644
> >--- a/drivers/net/mdio/of_mdio.c
> >+++ b/drivers/net/mdio/of_mdio.c
> >@@ -231,6 +231,7 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
> > return 0;
> >
> > unregister:
> >+ of_node_put(child);
> > mdiobus_unregister(mdio);
> > return rc;
> > }
> >--
> >2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] of: mdio: Add of_node_put() when breaking out of for_each_xx
2022-09-13 12:56 [PATCH v2] of: mdio: Add of_node_put() when breaking out of for_each_xx Liang He
2022-09-13 15:13 ` Liang He
@ 2022-09-20 14:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-09-20 14:50 UTC (permalink / raw)
To: Liang He
Cc: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni, netdev,
linmq006
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 13 Sep 2022 20:56:59 +0800 you wrote:
> In of_mdiobus_register(), we should call of_node_put() for 'child'
> escaped out of for_each_available_child_of_node().
>
> Fixes: 66bdede495c7 ("of_mdio: Fix broken PHY IRQ in case of probe deferral")
> Cc: Miaoqian Lin <linmq006@gmail.com>
> Co-developed-by: Miaoqian Lin <linmq006@gmail.com>
> Signed-off-by: Liang He <windhl@126.com>
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
>
> [...]
Here is the summary with links:
- [v2] of: mdio: Add of_node_put() when breaking out of for_each_xx
https://git.kernel.org/netdev/net/c/1c48709e6d9d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-20 14:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-13 12:56 [PATCH v2] of: mdio: Add of_node_put() when breaking out of for_each_xx Liang He
2022-09-13 15:13 ` Liang He
2022-09-15 16:51 ` [PATCH " Miaoqian Lin
2022-09-20 14:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).