From: Paolo Abeni <pabeni@redhat.com>
To: chia-yu.chang@nokia-bell-labs.com, parav@nvidia.com,
saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com,
leonro@nvidia.com
Cc: shenjian15@huawei.com, shaojijie@huawei.com,
andrew+netdev@lunn.ch, linyunsheng@huawei.com, mst@redhat.com,
jasowang@redhat.com, salil.mehta@huawei.com,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
davem@davemloft.net, edumazet@google.com, horms@kernel.org,
ij@kernel.org, ncardwell@google.com,
koen.de_schepper@nokia-bell-labs.com, g.white@cablelabs.com,
ingemar.s.johansson@ericsson.com, mirja.kuehlewind@ericsson.com,
Jason_Livingood@comcast.com, cheshire@apple.com, rs.ietf@gmx.at,
vidhi_goel@apple.com, kuba@kernel.org
Subject: Re: [PATCH v3 net 2/3] net: mlx5e: fix CWR handling in drivers to preserve ACE signal
Date: Thu, 19 Feb 2026 15:50:48 +0100 [thread overview]
Message-ID: <62393422-bc8f-4676-bf3c-4d1be15ab800@redhat.com> (raw)
In-Reply-To: <20260216085143.40242-3-chia-yu.chang@nokia-bell-labs.com>
On 2/16/26 9:51 AM, chia-yu.chang@nokia-bell-labs.com wrote:
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
> index efcfcddab376..64fb829e1f0f 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
> @@ -1137,7 +1137,7 @@ static void mlx5e_shampo_update_ipv4_tcp_hdr(struct mlx5e_rq *rq, struct iphdr *
> skb->csum_offset = offsetof(struct tcphdr, check);
>
> if (tcp->cwr)
> - skb_shinfo(skb)->gso_type |= SKB_GSO_TCP_ECN;
> + skb_shinfo(skb)->gso_type |= SKB_GSO_TCP_ACCECN;
Is the above enough or will later segmentation lead to wrong results? I
think/guess the firmware is (still) aggregating the wire frames using
the ECN schema, i.e. the first wire packet has CWR == 1, the later CWR==0.
Later segmentation of this GSO packet will emit CWR == 1 on all the
packets, making the egress stream different from ingress.
The above question is mostly for Mellanox person, I guess..
/P
next prev parent reply other threads:[~2026-02-19 14:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 8:51 [PATCH v3 net 0/3] ECN offload handling for AccECN series chia-yu.chang
2026-02-16 8:51 ` [PATCH v3 net 1/3] net: update comments for SKB_GSO_TCP_ECN and SKB_GSO_TCP_ACCECN chia-yu.chang
2026-02-16 8:51 ` [PATCH v3 net 2/3] net: mlx5e: fix CWR handling in drivers to preserve ACE signal chia-yu.chang
2026-02-19 14:35 ` Paolo Abeni
2026-02-19 14:50 ` Paolo Abeni [this message]
2026-02-16 8:51 ` [PATCH v3 net 3/3] net: hns3: " chia-yu.chang
2026-02-19 14:52 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62393422-bc8f-4676-bf3c-4d1be15ab800@redhat.com \
--to=pabeni@redhat.com \
--cc=Jason_Livingood@comcast.com \
--cc=andrew+netdev@lunn.ch \
--cc=cheshire@apple.com \
--cc=chia-yu.chang@nokia-bell-labs.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=g.white@cablelabs.com \
--cc=horms@kernel.org \
--cc=ij@kernel.org \
--cc=ingemar.s.johansson@ericsson.com \
--cc=jasowang@redhat.com \
--cc=koen.de_schepper@nokia-bell-labs.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=mbloch@nvidia.com \
--cc=mirja.kuehlewind@ericsson.com \
--cc=mst@redhat.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=rs.ietf@gmx.at \
--cc=saeedm@nvidia.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=tariqt@nvidia.com \
--cc=vidhi_goel@apple.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox