From: Eric Dumazet <eric.dumazet@gmail.com>
To: Mianhan Liu <liumh1@shanghaitech.edu.cn>,
Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthew <Wilcoxwilly@infradead.org>
Subject: Re: [PATCH -next] net/ipv4/tcp.c: remove superfluous header file in tcp.c
Date: Wed, 11 Aug 2021 16:19:20 +0200 [thread overview]
Message-ID: <6240ae70-3a50-2570-a115-c61ef09286a6@gmail.com> (raw)
In-Reply-To: <20210811133305.14640-1-liumh1@shanghaitech.edu.cn>
On 8/11/21 3:33 PM, Mianhan Liu wrote:
> nr_free_buffer_pages could be exposed through mm.h instead of swap.h,
> and then tcp.c wouldn't need swap.h. Moreover, after preprocessing
> all the files that use nr_free_buffer_pages, it turns out that those files
> have already included mm.h.
> Thus, we can move nr_free_buffer_pages from swap.h to mm.h safely
> so as to reduce the obsolete includes.
>
> Signed-off-by: MianHan Liu <liumh1@shanghaitech.edu.cn>
Not sure why tcp gets a special treatment.
Patch title does not match changelog at all.
You should submit a pure mm patch, then eventually one networking follow up.
# git grep -n linux/swap.h -- net
net/9p/trans_virtio.c:34:#include <linux/swap.h>
net/ipv4/sysctl_net_ipv4.c:18:#include <linux/swap.h>
net/ipv4/tcp.c:263:#include <linux/swap.h>
net/ipv4/udp.c:81:#include <linux/swap.h>
net/netfilter/ipvs/ip_vs_ctl.c:27:#include <linux/swap.h>
net/openvswitch/meter.c:15:#include <linux/swap.h>
net/sctp/protocol.c:36:#include <linux/swap.h>
next prev parent reply other threads:[~2021-08-11 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 13:33 [PATCH -next] net/ipv4/tcp.c: remove superfluous header file in tcp.c Mianhan Liu
2021-08-11 14:19 ` Eric Dumazet [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-08-11 13:56 Mianhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6240ae70-3a50-2570-a115-c61ef09286a6@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=Wilcoxwilly@infradead.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liumh1@shanghaitech.edu.cn \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).