Re: [Patch net-next v3] net: phy: Add driver for Motorcomm Quad 2.5GbE phy

[Krzysztof Kozlowski <krzk@kernel.org>]

On 17/07/2026 07:48, Kyle Switch wrote:
> Add a driver for motorcomm yt8824 quad 2.5G ethernet phy, supports
> 2.5G/1000M/100M/10M speed.
> 
> Signed-off-by: Kyle Switch <kyle.switch@motor-comm.com>

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument, so you will
not CC people just because they made one commit years ago). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

> ---
> 
> changes in v3:
> 1. Using common apis defined in phy_package.c to handle shared top
> extend register space.
> 2. Add dts demo in motorcomm,yt8xxx.yaml.
> 3. Fix unnecessary redundant judgments.
> 4. Fix BMCR registers operation using magic number.
> 5. Rename funtion based on its approximate functionality.
> 
> changes in v2:
> 1. Remove duplicate code and replace it with existing api. 
> 
>  .../bindings/net/motorcomm,yt8xxx.yaml        |   30 +
>  drivers/net/phy/motorcomm.c                   | 1808 ++++++++++++++++-
>  2 files changed, 1750 insertions(+), 88 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml
> index 26688e2302ea..e7592468f658 100644
> --- a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml
> +++ b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml
> @@ -149,3 +149,33 @@ examples:
>              motorcomm,auto-sleep-disabled;
>          };
>      };
> +  - |
> +    mdio {
> +        #address-cells = <1>;
> +        #size-cells = <0>;

I don't understand why you are doing this. Anyway, please read the
documents I linked and maybe there is some explanation for that change.

Best regards,
Krzysztof