From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Maxim Korotkov <korotkov.maxim.s@gmail.com>,
Rasesh Mody <rmody@marvell.com>
Cc: GR-Linux-NIC-Dev@marvell.com,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Michael Chan <mchan@broadcom.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] bnx2: remove deadcode in bnx2_init_cpus()
Date: Sat, 18 Feb 2023 16:13:19 +0000 [thread overview]
Message-ID: <62832516-d4b9-add6-4925-1caeaa33d167@linux.dev> (raw)
In-Reply-To: <20230218130016.42856-1-korotkov.maxim.s@gmail.com>
On 18.02.2023 13:00, Maxim Korotkov wrote:
> The load_cpu_fw function has no error return code
> and always returns zero. Checking the value returned by
> this function does not make sense.
> As a result, bnx2_init_cpus will also return only zero
>
In this case it's safe to convert both load_cpu_fw and bnx2_init_cpus to void
and remove the check in bnx2_init_chip. This will reduce the code a bit.
next prev parent reply other threads:[~2023-02-18 16:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-18 13:00 [PATCH] bnx2: remove deadcode in bnx2_init_cpus() Maxim Korotkov
2023-02-18 16:13 ` Vadim Fedorenko [this message]
2023-02-19 9:48 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62832516-d4b9-add6-4925-1caeaa33d167@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=korotkov.maxim.s@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmody@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).