From: John Fastabend <john.fastabend@gmail.com>
To: Roberto Sassu <roberto.sassu@huawei.com>,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
kpsingh@kernel.org, john.fastabend@gmail.com,
songliubraving@fb.com, kafai@fb.com, yhs@fb.com
Cc: dhowells@redhat.com, keyrings@vger.kernel.org,
bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Roberto Sassu <roberto.sassu@huawei.com>
Subject: RE: [PATCH v5 4/5] selftests/bpf: Add test for unreleased key references
Date: Tue, 21 Jun 2022 15:35:37 -0700 [thread overview]
Message-ID: <62b247b975506_162742082f@john.notmuch> (raw)
In-Reply-To: <20220621163757.760304-5-roberto.sassu@huawei.com>
Roberto Sassu wrote:
> Ensure that the verifier detects the attempt of acquiring a reference of a
> key through the helper bpf_lookup_user_key(), without releasing that
> reference with bpf_key_put(), and refuses to load the program.
>
> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
> ---
Any reason not to add these to ./verifier/ref_tracking.c tests? Seems it
might be easier to follow there and test both good/bad cases.
next prev parent reply other threads:[~2022-06-21 22:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 16:37 [PATCH v5 0/5] bpf: Add bpf_verify_pkcs7_signature() helper Roberto Sassu
2022-06-21 16:37 ` [PATCH v5 1/5] bpf: Export bpf_dynptr_get_size() Roberto Sassu
2022-06-21 16:37 ` [PATCH v5 2/5] bpf: Add bpf_lookup_user_key() and bpf_key_put() helpers Roberto Sassu
2022-06-21 22:32 ` Alexei Starovoitov
2022-06-22 7:12 ` Roberto Sassu
2022-06-23 12:36 ` Roberto Sassu
2022-06-23 20:54 ` Alexei Starovoitov
2022-06-24 15:32 ` Roberto Sassu
2022-06-24 16:50 ` Alexei Starovoitov
2022-06-24 17:38 ` Roberto Sassu
2022-06-24 15:59 ` Roberto Sassu
2022-06-21 16:37 ` [PATCH v5 3/5] bpf: Add bpf_verify_pkcs7_signature() helper Roberto Sassu
2022-06-21 22:27 ` John Fastabend
2022-06-22 9:54 ` Roberto Sassu
2022-06-23 1:27 ` John Fastabend
2022-06-21 16:37 ` [PATCH v5 4/5] selftests/bpf: Add test for unreleased key references Roberto Sassu
2022-06-21 22:35 ` John Fastabend [this message]
2022-06-22 7:14 ` Roberto Sassu
2022-06-21 16:37 ` [PATCH v5 5/5] selftests/bpf: Add test for bpf_verify_pkcs7_signature() helper Roberto Sassu
2022-06-21 22:31 ` Alexei Starovoitov
2022-06-22 7:06 ` Roberto Sassu
2022-06-22 18:16 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62b247b975506_162742082f@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dhowells@redhat.com \
--cc=kafai@fb.com \
--cc=keyrings@vger.kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roberto.sassu@huawei.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).