From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55674C282C2 for ; Sun, 10 Feb 2019 14:28:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 041BD207E0 for ; Sun, 10 Feb 2019 14:28:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AM+4yg2v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726231AbfBJO2O (ORCPT ); Sun, 10 Feb 2019 09:28:14 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:36937 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726158AbfBJO2O (ORCPT ); Sun, 10 Feb 2019 09:28:14 -0500 Received: by mail-wm1-f67.google.com with SMTP id x10so6637871wmg.2 for ; Sun, 10 Feb 2019 06:28:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AoIDwYZ567STYjGwNF8QrIvd0pWxhccrILWbvxZIg0U=; b=AM+4yg2vVCd4aGu3lf5cznuWHwirFeeg/ml+E6gqdcs0Yz6YNmf1Tm1K2CzOzjnx87 ByMx1adAsl39yyHqbYcsnj4U+FgQ8XpwYHwbbrFREqjP9bbBKMxfw3o0zbwZWZjDvfQw GExt69FEjXFPsVJT7qmWSddLtsVWBnESCB5B+lnfLZJotGsJUWlRJvwpxcfP4sz2bIGa 9joqS3RNCmJo/9lJGpP9h92mvH8ssKbCLb7+T4j8gAddWpR23yKHWC+TbJ5su/7pPn95 0+mhFKWLVUygkaqStZSDaAYX14Cb2W0CaDFHWPCyY0zL1bdpsZFYM7tH71uIQKj3zRWR y2bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AoIDwYZ567STYjGwNF8QrIvd0pWxhccrILWbvxZIg0U=; b=XH6JZk+HqJ1w/Tg56Q/FsqvFh/ap13H26u/WZ3OWD1MUV2SBanVjmspPPyxqU1N+x2 uFmToU6XhXBKQNy1z4Mv0To5F/UpPS3zdX6enx1Cp6lVJzbAs9Vbo2gj1KAPnWxEaFIG bABFxtXoOhGSQ2+EQ0WxIYkfg1cJ89X3tQogCYfJ53mR34p1zldLXNXY3RXFtM5YZi8t mOWDq9YtqSTZuHlYN54hkL4S6HWSTaQveRihiPCQ7taEs+YHGldnzZTH9afAjKfx0mAy IfNxX1w89wurBFaMQXILG1EGlVNl+OWAzRwbh80vABZ/vgQ/C02I2t+mHuK36q53/UbK kMiw== X-Gm-Message-State: AHQUAuaEkdfsaOqanyUudHItMJgawZ/UElQKVtrMfCX92ZT+Fjb7Plli +UbapZk9u9Olk1OluZPHbunOQpYj X-Google-Smtp-Source: AHgI3IbN5o0qZCxEzogbk07J8MokjlrpcOib4kfHNL9AH6NFhAHM6Zlbc6Bnd7hlegQ+lA/KnL1UXw== X-Received: by 2002:adf:ce90:: with SMTP id r16mr5854298wrn.64.1549808892207; Sun, 10 Feb 2019 06:28:12 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:1513:f24d:17d6:1a6d? (p200300EA8BF1E2001513F24D17D61A6D.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:1513:f24d:17d6:1a6d]) by smtp.googlemail.com with ESMTPSA id 65sm28970360wrb.62.2019.02.10.06.28.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Feb 2019 06:28:11 -0800 (PST) Subject: [PATCH v2 net 1/2] Revert "r8169: remove unneeded mmiowb barriers" From: Heiner Kallweit To: Realtek linux nic maintainers , David Miller Cc: Sander Eikelenboom , "netdev@vger.kernel.org" References: <63e9e767-f78b-8865-fe25-41d77e4e7a58@gmail.com> Message-ID: <62b828d9-f90a-059c-e61a-e747c389d44d@gmail.com> Date: Sun, 10 Feb 2019 15:26:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <63e9e767-f78b-8865-fe25-41d77e4e7a58@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This reverts commit bd7153bd83b806bfcc2e79b7a6f43aa653d06ef3. There doesn't seem to be anything wrong with this patch, it's just reverted to get a stable baseline again. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index abb94c543aa2..bba806ce57d3 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -1286,11 +1286,13 @@ static u16 rtl_get_events(struct rtl8169_private *tp) static void rtl_ack_events(struct rtl8169_private *tp, u16 bits) { RTL_W16(tp, IntrStatus, bits); + mmiowb(); } static void rtl_irq_disable(struct rtl8169_private *tp) { RTL_W16(tp, IntrMask, 0); + mmiowb(); } #define RTL_EVENT_NAPI_RX (RxOK | RxErr) @@ -6130,8 +6132,10 @@ static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb, if (unlikely(stop_queue)) netif_stop_queue(dev); - if (__netdev_sent_queue(dev, skb->len, skb->xmit_more)) + if (__netdev_sent_queue(dev, skb->len, skb->xmit_more)) { RTL_W8(tp, TxPoll, NPQ); + mmiowb(); + } if (unlikely(stop_queue)) { /* Sync with rtl_tx: @@ -6483,7 +6487,9 @@ static int rtl8169_poll(struct napi_struct *napi, int budget) if (work_done < budget) { napi_complete_done(napi, work_done); + rtl_irq_enable(tp); + mmiowb(); } return work_done; -- 2.20.1