From: Hagen Paul Pfeifer <hagen@jauu.net>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <kaber@trash.net>,
<eric.dumazet@gmail.com>, <ilpo.jarvinen@helsinki.fi>
Subject: Re: [PATCH] tcp: allow effective reduction of TCP's rcv-buffer via setsockopt
Date: Thu, 19 Aug 2010 08:58:46 +0200 [thread overview]
Message-ID: <62cfdf78ab776307fb132a5c8fde128e@localhost> (raw)
In-Reply-To: <20100818.233337.52187393.davem@davemloft.net>
On Wed, 18 Aug 2010 23:33:37 -0700 (PDT), David Miller wrote:
> From: Hagen Paul Pfeifer <hagen@jauu.net>
> Date: Sun, 15 Aug 2010 21:36:16 +0200
>
>> +
>> + if (sk->sk_userlocks & SOCK_RCVBUF_LOCK &&
>> + (req->window_clamp > tcp_full_space(sk) || req->window_clamp ==
0))
>> + req->window_clamp = tcp_full_space(sk);
>> +
>
> Logically the patch looks fine, but please fix the indentation of the
> second line of the two new if() statements in this patch, the
> second line's first character should line up with the character
> right after the openning "(" on the previous line.
Sorry Dave, I played with my vim settings ... I will resubmit the patch.
;-)
next prev parent reply other threads:[~2010-08-19 6:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-15 19:36 [PATCH] tcp: allow effective reduction of TCP's rcv-buffer via setsockopt Hagen Paul Pfeifer
2010-08-19 6:33 ` David Miller
2010-08-19 6:58 ` Hagen Paul Pfeifer [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-08-19 16:33 Hagen Paul Pfeifer
2010-08-23 4:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62cfdf78ab776307fb132a5c8fde128e@localhost \
--to=hagen@jauu.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).