From: Christian Marangi <ansuelsmth@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jens Axboe <axboe@kernel.dk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH] net: dsa: qca8k: move driver to qca dir
Date: Fri, 15 Jul 2022 21:16:46 +0200 [thread overview]
Message-ID: <62d1c288.1c69fb81.45988.55fe@mx.google.com> (raw)
In-Reply-To: <20220715123743.419537e7@kernel.org>
On Fri, Jul 15, 2022 at 12:37:43PM -0700, Jakub Kicinski wrote:
> On Fri, 15 Jul 2022 03:57:46 +0200 Christian Marangi wrote:
> > > Does the split mean that this code will move again?
> > > If so perhaps better to put this patch in the series
> > > that does the split? We're ~2 weeks away from the merge
> > > window so we don't want to end up moving the same code
> > > twice in two consecutive releases.
> >
> > What to you mean with "will move again"?
> >
> > The code will be split to qca8k-common.c and qca8k-8xxx.c
> > And later qca8k-ipq4019.c will be proposed.
> >
> > So the files will all stay in qca/ dir.
> >
> > Or should I just propose the move and the code split in one series?
>
> Yup that's what I prefer.
>
Ok no problem, if the current merged commit is a problem, np for me with
a revert! (it was really to prevent sending a bigger series, sorry for
the mess)
> > Tell me what do you prefer.
--
Ansuel
next prev parent reply other threads:[~2022-07-15 19:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 20:53 [net-next PATCH] net: dsa: qca8k: move driver to qca dir Christian Marangi
2022-07-13 21:02 ` Florian Fainelli
2022-07-15 5:03 ` Jakub Kicinski
2022-07-15 1:57 ` Christian Marangi
2022-07-15 19:37 ` Jakub Kicinski
2022-07-15 19:16 ` Christian Marangi [this message]
2022-07-15 19:47 ` Jakub Kicinski
2022-07-15 19:25 ` Christian Marangi
2022-07-15 11:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62d1c288.1c69fb81.45988.55fe@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=andrew@lunn.ch \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).