From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1966CC10F03 for ; Tue, 23 Apr 2019 15:52:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9CC82175B for ; Tue, 23 Apr 2019 15:52:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728404AbfDWPwl (ORCPT ); Tue, 23 Apr 2019 11:52:41 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([207.82.80.151]:35418 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727180AbfDWPwl (ORCPT ); Tue, 23 Apr 2019 11:52:41 -0400 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-44-bB6UZHrnPm-A0mPoTAYpsA-1; Tue, 23 Apr 2019 16:52:38 +0100 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Tue, 23 Apr 2019 16:53:50 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Tue, 23 Apr 2019 16:53:50 +0100 From: David Laight To: 'Willem de Bruijn' CC: "netdev@vger.kernel.org" , "davem@davemloft.net" , "idosch@idosch.org" , "Willem de Bruijn" Subject: RE: [PATCH net] packet: validate address length if non-zero Thread-Topic: [PATCH net] packet: validate address length if non-zero Thread-Index: AQHUmkDdSvpkaV9kXkOyGO8KJ3nLv6ZKP8XAgABHlICAABkn4A== Date: Tue, 23 Apr 2019 15:53:50 +0000 Message-ID: <62f0a1c528b04e9eaa863179e227165a@AcuMS.aculab.com> References: <20181222215345.128704-1-willemdebruijn.kernel@gmail.com> <28df499bec4146fdbd9d66a6bf7dc621@AcuMS.aculab.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-MC-Unique: bB6UZHrnPm-A0mPoTAYpsA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org RnJvbTogV2lsbGVtIGRlIEJydWlqbg0KPiBTZW50OiAyMyBBcHJpbCAyMDE5IDE2OjA4DQo+IE9u IFR1ZSwgQXByIDIzLCAyMDE5IGF0IDU6NTkgQU0gRGF2aWQgTGFpZ2h0IDxEYXZpZC5MYWlnaHRA YWN1bGFiLmNvbT4gd3JvdGU6DQo+ID4NCj4gPiBGcm9tOiBXaWxsZW0gZGUgQnJ1aWpuDQo+ID4g PiBTZW50OiAyMiBEZWNlbWJlciAyMDE4IDIxOjU0DQo+ID4gPiBWYWxpZGF0ZSBwYWNrZXQgc29j a2V0IGFkZHJlc3MgbGVuZ3RoIGlmIGEgbGVuZ3RoIGlzIGdpdmVuLiBaZXJvDQo+ID4gPiBsZW5n dGggaXMgZXF1aXZhbGVudCB0byBub3Qgc2V0dGluZyBhbiBhZGRyZXNzLg0KPiA+ID4NCj4gPiA+ IEZpeGVzOiA5OTEzN2I3ODg4ZjQgKCJwYWNrZXQ6IHZhbGlkYXRlIGFkZHJlc3MgbGVuZ3RoIikN Cj4gPiA+IFJlcG9ydGVkLWJ5OiBJZG8gU2NoaW1tZWwgPGlkb3NjaEBpZG9zY2gub3JnPg0KPiA+ ID4gU2lnbmVkLW9mZi1ieTogV2lsbGVtIGRlIEJydWlqbiA8d2lsbGVtYkBnb29nbGUuY29tPg0K PiA+ID4gLS0tDQo+ID4gPiAgbmV0L3BhY2tldC9hZl9wYWNrZXQuYyB8IDQgKystLQ0KPiA+ID4g IDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQo+ID4gPg0K PiA+ID4gZGlmZiAtLWdpdCBhL25ldC9wYWNrZXQvYWZfcGFja2V0LmMgYi9uZXQvcGFja2V0L2Fm X3BhY2tldC5jDQo+ID4gPiBpbmRleCA1ZGRhMjYzYjRhMGEuLmVlZGFjZGViY2Q0YyAxMDA2NDQN Cj4gPiA+IC0tLSBhL25ldC9wYWNrZXQvYWZfcGFja2V0LmMNCj4gPiA+ICsrKyBiL25ldC9wYWNr ZXQvYWZfcGFja2V0LmMNCj4gPiA+IEBAIC0yNjI1LDcgKzI2MjUsNyBAQCBzdGF0aWMgaW50IHRw YWNrZXRfc25kKHN0cnVjdCBwYWNrZXRfc29jayAqcG8sIHN0cnVjdCBtc2doZHIgKm1zZykNCj4g PiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzbGxfYWRk cikpKQ0KPiA+ID4gICAgICAgICAgICAgICAgICAgICAgIGdvdG8gb3V0Ow0KPiA+ID4gICAgICAg ICAgICAgICBwcm90byAgID0gc2FkZHItPnNsbF9wcm90b2NvbDsNCj4gPiA+IC0gICAgICAgICAg ICAgYWRkciAgICA9IHNhZGRyLT5zbGxfYWRkcjsNCj4gPiA+ICsgICAgICAgICAgICAgYWRkciAg ICA9IHNhZGRyLT5zbGxfaGFsZW4gPyBzYWRkci0+c2xsX2FkZHIgOiBOVUxMOw0KPiA+ID4gICAg ICAgICAgICAgICBkZXYgPSBkZXZfZ2V0X2J5X2luZGV4KHNvY2tfbmV0KCZwby0+c2spLCBzYWRk ci0+c2xsX2lmaW5kZXgpOw0KPiA+ID4gICAgICAgICAgICAgICBpZiAoYWRkciAmJiBkZXYgJiYg c2FkZHItPnNsbF9oYWxlbiA8IGRldi0+YWRkcl9sZW4pDQo+ID4gPiAgICAgICAgICAgICAgICAg ICAgICAgZ290byBvdXQ7DQo+ID4gPiBAQCAtMjgyNSw3ICsyODI1LDcgQEAgc3RhdGljIGludCBw YWNrZXRfc25kKHN0cnVjdCBzb2NrZXQgKnNvY2ssIHN0cnVjdCBtc2doZHIgKm1zZywgc2l6ZV90 IGxlbikNCj4gPiA+ICAgICAgICAgICAgICAgaWYgKG1zZy0+bXNnX25hbWVsZW4gPCAoc2FkZHIt PnNsbF9oYWxlbiArIG9mZnNldG9mKHN0cnVjdCBzb2NrYWRkcl9sbCwgc2xsX2FkZHIpKSkNCj4g PiA+ICAgICAgICAgICAgICAgICAgICAgICBnb3RvIG91dDsNCj4gPiA+ICAgICAgICAgICAgICAg cHJvdG8gICA9IHNhZGRyLT5zbGxfcHJvdG9jb2w7DQo+ID4gPiAtICAgICAgICAgICAgIGFkZHIg ICAgPSBzYWRkci0+c2xsX2FkZHI7DQo+ID4gPiArICAgICAgICAgICAgIGFkZHIgICAgPSBzYWRk ci0+c2xsX2hhbGVuID8gc2FkZHItPnNsbF9hZGRyIDogTlVMTDsNCj4gPiA+ICAgICAgICAgICAg ICAgZGV2ID0gZGV2X2dldF9ieV9pbmRleChzb2NrX25ldChzayksIHNhZGRyLT5zbGxfaWZpbmRl eCk7DQo+ID4gPiAgICAgICAgICAgICAgIGlmIChhZGRyICYmIGRldiAmJiBzYWRkci0+c2xsX2hh bGVuIDwgZGV2LT5hZGRyX2xlbikNCj4gPiA+ICAgICAgICAgICAgICAgICAgICAgICBnb3RvIG91 dDsNCj4gPiA+IC0tDQo+ID4gPiAyLjIwLjEuNDE1Lmc2NTM2MTNjNzIzLWdvb2cNCj4gPg0KPiA+ IFdlJ3ZlIGp1c3QgZGlzY292ZXJlZCB0aGUgY29tYmluYXRpb24gb2YgdGhpcyBwYXRjaCBhbmQg dGhlIG9uZSBpdCAnZml4ZXMnDQo+ID4gYnJlYWtzIHNvbWUgb2Ygb3VyIHVzZXJzcGFjZSBjb2Rl Lg0KPiA+DQo+ID4gUHJpb3IgdG8gdGhlc2UgY2hhbmdlcyBpdCBkaWRuJ3QgbWF0dGVyIGlmIGNv ZGUgdXNpbmcgQUZfUEFDS0VUIHRvDQo+ID4gc2VuZCBldGhlcm5ldCBmcmFtZXMgb24gYSBzcGVj aWZpYyAnZXRoZXJ0eXBlJyBmYWlsZWQgdG8gc2V0IHNsbF9hZGRyLg0KPiA+IEV2ZXJ5dGhpbmcg YXNzdW1lZCBpdCB3b3VsZCBiZSA2IC0gYW5kIHRoZSBwYWNrZXRzIHdlcmUgc2VudC4NCj4gPg0K PiA+IFdpdGggYm90aCBjaGFuZ2VzIHlvdSBnZXQgYSAtRUlOVkFMIHJldHVybiBmcm9tIHNvbWV3 aGVyZS4NCj4gPiBJIGNhbiBmaXggb3VyIGNvZGUsIGJ1dCBJIGRvdWJ0IGl0IGlzIHRoZSBvbmx5 IGNvZGUgYWZmZWN0ZWQuDQo+ID4gT3RoZXIgcGVvcGxlIGFyZSBsaWtlbHkgdG8gaGF2ZSBjb3Bp ZWQgdGhlIHNhbWUgZXhhbXBsZS4NCj4gDQo+IFRoYW5rcyBmb3IgdGhlIHJlcG9ydC4NCj4gDQo+ IFVzYWdlIHRydW1wcyBjb3JyZWN0bmVzcy4gQnV0IHRoaXMgc2VlbXMgdG8gYmUgYSBjYXNlIG9m IGRhbW5lZCBpZiB5b3UNCj4gZG8sIGRhbW5lZCBpZiB5b3UgZG9uJ3QuDQo+IA0KPiBTeXpib3Qg Zm91bmQgYSByZWFsIHVzZSBjYXNlIG9mIHJlYWRpbmcgYmV5b25kIHRoZSBlbmQgb2YNCj4gbXNn LT5tc2dfbmFtZWxlbiwgc2luY2UgdGhhdCBpcyBjaGVja2VkIGFnYWluc3QNCj4gDQo+ICAgICAg ICAgICAgICAgICBpZiAobXNnLT5tc2dfbmFtZWxlbiA8IChzYWRkci0+c2xsX2hhbGVuICsNCj4g b2Zmc2V0b2Yoc3RydWN0IHNvY2thZGRyX2xsLCBzbGxfYWRkcikpKQ0KPiANCj4gSnVzdCBhc3N1 bWluZyB0aGF0IGFkZHJlc3MgbGVuZ3RoIGlzIGRldi0+YWRkcl9sZW4gYWxsb3dzIGFuDQo+IG5z X2NhcGFibGUgcm9vdCB0byBidWlsZCBsaW5rIGxheWVyIHBhY2tldHMgd2l0aCBhZGRyZXNzIHNl dCB0bw0KPiB1bmluaXRpYWxpemVkIGRhdGEuDQo+IA0KPiBFdGhlcm5ldCBpcyBub3QgdGhlIG1v c3QgcHJvYmxlbWF0aWMgbGluayBsYXllci4gSW5kZWVkLCBzaW5jZQ0KPiBFVEhfQUxFTiA8IHNp emVvZihzbGxfYWRkciksIHRoZSBwcmV2aW91cyBjaGVjaw0KPiANCj4gICAgICAgICAgICAgICAg IGlmIChtc2ctPm1zZ19uYW1lbGVuIDwgc2l6ZW9mKHN0cnVjdCBzb2NrYWRkcl9sbCkpDQo+IA0K PiBXaWxsIGJlIHN1ZmZpY2llbnQgaW4gdGhpcyBjYXNlLiBUaGUgc3l6Ym90IHJlcG9ydCB3YXMg b24gYSBkZXZpY2Ugb2YNCj4gdHlwZSBpcDZncmUsIHdpdGggYWRkcl9sZW4gc2l6ZW9mKHN0cnVj dCBpbjZfYWRkcikuDQo+IA0KPiBTbyBJIGNhbiByZWZpbmUgdG8gb25seSBwZXJmb3JtIHRoZSBj aGVjayBvbiBwcm90b2NvbHMgd2l0aCBhZGRyX2xlbg0KPiA+PSBzaXplb2Yoc2xsX2FkZHIpLCBl eGNsdWRpbmcgRXRoZXJuZXQuDQoNCk1heWJlIHNvbWV0aGluZyBsaWtlOg0KCQlhZGRyICAgID0g c2FkZHItPnNsbF9hZGRyOw0KCQlkZXYgPSBkZXZfZ2V0X2J5X2luZGV4KHNvY2tfbmV0KHNrKSwg c2FkZHItPnNsbF9pZmluZGV4KTsNCgkJaWYgKGRldiAmJiBtc2ctPm1zZ19uYW1lbGVuIDwgKGRl di0+YWRkcl9sZW4NCgkJCQkJKyBvZmZzZXRvZihzdHJ1Y3Qgc29ja2FkZHJfbGwsDQoJCQkJCQlz bGxfYWRkcikpKQ0KCQkJLyogRG9uJ3QgcmVhZCBhZGRyZXNzIGZyb20gYmV5b25kIHRoZSBlbmQg b2YgdGhlIGJ1ZmZlciAqLw0KCQkJZ290byBvdXQ7DQoNClNvIGl0IGp1c3QgY2hlY2tzIHRoYXQg YWxsIG9mIHRoZSBhZGRyZXNzIGlzIGluIHRoZSBidWZmZXIgcGFzc2VkDQpmcm9tIHRoZSB1c2Vy Lg0KDQpBbHRob3VnaCBJJ2Qgd3JpdGUgdGhvc2UgdGVzdHMgaW4gYSBkaWZmZXJlbnQgb3JkZXI6 DQoJCWlmIChkZXYgJiYgb2Zmc2V0b2Yoc3RydWN0IHNvY2thZGRyX2xsLCBzbGxfYWRkcikgKyBk ZXYtPmFkZHJfbGVuID4gbXNnLT5tc2dfbmFtZWxlbikNCgkJCWdvdG8gb3V0Ow0KDQpGV0lXIHRo ZSByZWxldmFudCBhcHBsaWNhdGlvbiBjb2RlIGhhcyBiZWVuIGluIG91ciBjdnMgdHJlZSBmb3Ig MTMgeWVhcnMuDQpNYXJrIEJyb3duIG1pZ2h0IHJlbWVtYmVyIHdoZXJlIGhlIHN0b2xlIGl0IGZy b20gOi0pDQoNCglEYXZpZA0KDQotDQpSZWdpc3RlcmVkIEFkZHJlc3MgTGFrZXNpZGUsIEJyYW1s ZXkgUm9hZCwgTW91bnQgRmFybSwgTWlsdG9uIEtleW5lcywgTUsxIDFQVCwgVUsNClJlZ2lzdHJh dGlvbiBObzogMTM5NzM4NiAoV2FsZXMpDQo=