From: CGEL <cgel.zte@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, xu.xin16@zte.com.cn
Subject: Re: [PATCH 0/2] Namespaceify two sysctls related with route
Date: Tue, 23 Aug 2022 01:56:06 +0000 [thread overview]
Message-ID: <630433b7.630a0220.6ca31.e01f@mx.google.com> (raw)
In-Reply-To: <20220817205237.3e701f0b@kernel.org>
On Wed, Aug 17, 2022 at 08:52:37PM -0700, Jakub Kicinski wrote:
> On Tue, 16 Aug 2022 02:25:22 +0000 cgel.zte@gmail.com wrote:
> > Different netns has different requirements on the setting of error_cost
> > and error_burst, which are related with limiting the frequency of sending
> > ICMP_DEST_UNREACH packets or outputing error message to dmesg.
>
> Could you add a bit more detail about why you need this knob per netns?
Yes, I have sent new-version patches which update the commit lot at
https://lore.kernel.org/all/20220822045310.203649-1-xu.xin16@zte.com.cn/
The sysctls of error_cost and error_burst are important knobs to control
the sending frequency of ICMP_DEST_UNREACH packet for ipv4. When different
containers has requirements on the tuning of error_cost and error_burst,
for host's security, the sysctls should exist per network namespace so
not to bother the host's sysctl setting.
> The code looks fine, no objections there, what I'm confused by is that
> we don't have this knob for IPv6. So is it somehow important enough for
> v4 to be per-ns and yet not important enough to exist at all on v6?
>
Sorry, but I'm not familiar with IPv6 implementation.
> Could you add Documentation in Documentation/admin-guide/sysctl/net.rst
> while at it, and use READ_ONCE / WRITE_ONCE when accessing the sysctl?
>
Yes, done.
> Please make sure to CC the relevant maintainers. IP maintainers were
> not CCed here. The get_maintainers script will tell you who to CC,
> please use it.
Fine, done.
prev parent reply other threads:[~2022-08-23 1:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 2:25 [PATCH 0/2] Namespaceify two sysctls related with route cgel.zte
2022-08-16 2:26 ` [PATCH 1/2] ipv4: Namespaceify route/error_cost knob cgel.zte
2022-08-16 2:27 ` [PATCH 2/2] ipv4: Namespaceify route/error_burst knob cgel.zte
2022-08-18 3:52 ` [PATCH 0/2] Namespaceify two sysctls related with route Jakub Kicinski
2022-08-23 1:56 ` CGEL [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=630433b7.630a0220.6ca31.e01f@mx.google.com \
--to=cgel.zte@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xu.xin16@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).