From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joe Perches <joe@perches.com>
Subject: Re: [PATCH 1/4] net/ncsi: Silence debug messages
Date: Mon, 18 Jun 2018 13:49:09 -0700
Message-ID: <6304ffad4a55a78e0136aaa975e371b634f22af3.camel@perches.com>
References: <20180618071916.6765-1-joel@jms.id.au>
         <20180618071916.6765-2-joel@jms.id.au>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org
To: Joel Stanley <joel@jms.id.au>,
        Samuel Mendoza-Jonas <sam@mendozajonas.com>,
        "David S . Miller" <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from smtprelay0077.hostedemail.com ([216.40.44.77]:45663 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S935425AbeFRUtM (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 18 Jun 2018 16:49:12 -0400
In-Reply-To: <20180618071916.6765-2-joel@jms.id.au>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, 2018-06-18 at 16:49 +0930, Joel Stanley wrote:
> In normal operation we see this series of messages as the host drives
> the network device:
> 
>  ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state down
>  ftgmac100 1e660000.ethernet eth0: NCSI: suspending channel 0
[...]
> This makes all of these messages netdev_dbg. They are still useful to
> debug eg. misbehaving network device firmware, but we do not need them
> filling up the kernel logs in normal operation.

trivia:

> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
[]
> @@ -1735,7 +1735,7 @@ static void ftgmac100_ncsi_handler(struct ncsi_dev *nd)
>  	if (unlikely(nd->state != ncsi_dev_state_functional))
>  		return;
>  
> -	netdev_info(nd->dev, "NCSI interface %s\n",
> +	netdev_dbg(nd->dev, "NCSI interface %s\n",
>  		    nd->link_up ? "up" : "down");

It's nicer to realign the multiple line statements
to the open parenthesis

> diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c
[]
> @@ -73,8 +73,8 @@ static int ncsi_aen_handler_lsc(struct ncsi_dev_priv *ndp,
>  	ncm->data[2] = data;
>  	ncm->data[4] = ntohl(lsc->oem_status);
>  
> -	netdev_info(ndp->ndev.dev, "NCSI: LSC AEN - channel %u state %s\n",
> -		    nc->id, data & 0x1 ? "up" : "down");
> +	netdev_dbg(ndp->ndev.dev, "NCSI: LSC AEN - channel %u state %s\n",
> +		   nc->id, data & 0x1 ? "up" : "down");

as was done for the rest of these...