From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: [PATCH 06/10] staging/irda/net: Delete an unnecessary variable initialisation in two functions Date: Thu, 12 Oct 2017 12:46:03 +0200 Message-ID: <632598f6-c36d-a672-edfe-fbf62e9a2e25@users.sourceforge.net> References: <8152401b-d68d-c4fe-2619-82a09e0c52ec@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kernel-janitors@vger.kernel.org, LKML To: devel@driverdev.osuosl.org, netdev@vger.kernel.org, Al Viro , Corentin Labbe , David Howells , "David S. Miller" , Georgiana Chelu , Greg Kroah-Hartman , Johannes Berg , Julia Lawall , Samuel Ortiz , Srishti Sharma , Stephen Hemminger , Yuan Linyu Return-path: In-Reply-To: <8152401b-d68d-c4fe-2619-82a09e0c52ec@users.sourceforge.net> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: netdev.vger.kernel.org From: Markus Elfring Date: Wed, 11 Oct 2017 22:22:13 +0200 The local variable "tx_skb" will only be used in a single if branch of these functions. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/staging/irda/net/irlap_frame.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/irda/net/irlap_frame.c b/drivers/staging/irda/net/irlap_frame.c index 5b8be5b9812e..25ceb06efd58 100644 --- a/drivers/staging/irda/net/irlap_frame.c +++ b/drivers/staging/irda/net/irlap_frame.c @@ -862,7 +862,7 @@ void irlap_send_data_primary_poll(struct irlap_cb *self, struct sk_buff *skb) void irlap_send_data_secondary_final(struct irlap_cb *self, struct sk_buff *skb) { - struct sk_buff *tx_skb = NULL; + struct sk_buff *tx_skb; IRDA_ASSERT(self, return;); IRDA_ASSERT(self->magic == LAP_MAGIC, return;); @@ -922,7 +922,7 @@ void irlap_send_data_secondary_final(struct irlap_cb *self, */ void irlap_send_data_secondary(struct irlap_cb *self, struct sk_buff *skb) { - struct sk_buff *tx_skb = NULL; + struct sk_buff *tx_skb; /* Is this reliable or unreliable data? */ if (skb->data[1] == I_FRAME) { -- 2.14.2