From: John Fastabend <john.fastabend@gmail.com>
To: "Jakub Kicinski" <kuba@kernel.org>,
"Toke Høiland-Jørgensen" <toke@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Heng Qi <henqqi@linux.alibaba.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
bpf@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] veth: a couple of fixes
Date: Sun, 20 Nov 2022 22:15:02 -0800 [thread overview]
Message-ID: <637b1766420fe_b7b2208b3@john.notmuch> (raw)
In-Reply-To: <20221118170655.505702e5@kernel.org>
Jakub Kicinski wrote:
> On Fri, 18 Nov 2022 12:05:39 +0100 Toke Høiland-Jørgensen wrote:
> > FWIW, the original commit 2e0de6366ac1 was merged very quickly without
> > much review; so I'm not terribly surprised it breaks. I would personally
> > be OK with just reverting it...
>
> +1
Also fine with reverting my fix was mainly there to fix a CI test
that was failing. Apparently my quick fix wasn't nearly good enough.
next prev parent reply other threads:[~2022-11-21 6:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 23:33 [PATCH net-next 0/2] veth: a couple of fixes Paolo Abeni
2022-11-17 23:33 ` [PATCH net-next 1/2] veth: fix uninitialized napi disable Paolo Abeni
2022-11-17 23:33 ` [PATCH net-next 2/2] veth: fix double napi enable Paolo Abeni
2022-11-18 14:24 ` Heng Qi
2022-11-18 8:41 ` [PATCH net-next 0/2] veth: a couple of fixes Paolo Abeni
2022-11-18 11:05 ` Toke Høiland-Jørgensen
2022-11-19 1:06 ` Jakub Kicinski
2022-11-21 6:15 ` John Fastabend [this message]
2022-11-21 3:33 ` Xuan Zhuo
2022-11-21 3:55 ` Heng Qi
2022-11-21 10:11 ` Paolo Abeni
2022-11-21 11:28 ` [PATCH 0/2] Revert "veth: Avoid drop packets when xdp_redirect performs" and its fix Heng Qi
2022-11-21 11:28 ` [PATCH 1/2] Revert "bpf: veth driver panics when xdp prog attached before veth_open" Heng Qi
2022-11-21 11:28 ` [PATCH 2/2] Revert "veth: Avoid drop packets when xdp_redirect performs" Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=637b1766420fe_b7b2208b3@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=henqqi@linux.alibaba.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=toke@kernel.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).