From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:35285 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968436AbeCSSAH (ORCPT ); Mon, 19 Mar 2018 14:00:07 -0400 Received: by mail-wm0-f67.google.com with SMTP id r82so6883892wme.0 for ; Mon, 19 Mar 2018 11:00:06 -0700 (PDT) Subject: Re: [PATCH net-next 3/4] net: dsa: Plug in PHYLINK support To: Andrew Lunn Cc: netdev@vger.kernel.org, privat@egil-hjelmeland.no, vivien.didelot@savoirfairelinux.com, davem@davemloft.net, rmk+kernel@armlinux.org.uk, sean.wang@mediatek.com, Woojung.Huh@microchip.com, john@phrozen.org, cphealy@gmail.com References: <20180318185246.19311-1-f.fainelli@gmail.com> <20180318185246.19311-4-f.fainelli@gmail.com> <20180318191923.GN1188@lunn.ch> From: Florian Fainelli Message-ID: <639992a2-d651-8030-1a54-919e8e5827cf@gmail.com> Date: Mon, 19 Mar 2018 10:59:55 -0700 MIME-Version: 1.0 In-Reply-To: <20180318191923.GN1188@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: Hi Andrew, On 03/18/2018 12:19 PM, Andrew Lunn wrote: >> +static int dsa_slave_nway_reset(struct net_device *dev) >> +{ >> + struct dsa_port *dp = dsa_slave_to_port(dev); >> + >> + return phylink_ethtool_nway_reset(dp->pl); >> +} > > Hi Florian > > I've seen in one of Russells trees a patch to put a phylink into > net_device. That would make a generic slave_nway_reset() possible, and > a few others as well. Maybe it makes sense to pull in that patch? To make this generic, we would have to have net_device carry a reference to a phylink instance, which I would rather not do. Were you possibly referring to this patch set: http://git.armlinux.org.uk/cgit/linux-arm.git/commit/?h=phy&id=4eda3b76573473d811bc80a6f0e5a2e06dd76bf6 in which case I think it was discussed and rejected (that was my recollection). -- Florian