public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@kernel.org>
To: Eric Dumazet <edumazet@google.com>, Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH iproute2-next] tc: use ll_init_map() only when needed
Date: Sat, 2 May 2026 12:10:29 -0600	[thread overview]
Message-ID: <63c0e51d-77cb-4b05-80a2-adebe3317cd5@kernel.org> (raw)
In-Reply-To: <CANn89iLTH=_=qYS6RzqpGeCo2FuuVW70h_yRycy2L59G+APiew@mail.gmail.com>

On 5/2/26 11:25 AM, Eric Dumazet wrote:
> On Thu, Apr 30, 2026 at 11:20 AM Jamal Hadi Salim <jhs@mojatatu.com> wrote:
>>
>> On Thu, Apr 30, 2026 at 11:36 AM David Ahern <dsahern@kernel.org> wrote:
>>>
>>> Jamal: waiting for your review ...
>>>
>>> On 4/28/26 2:28 AM, Eric Dumazet wrote:
>>>> Some setups can have thousands of devices.
>>>>
>>>> ll_init_map() is rather expensive for them.
>>>>
>>>> Only call ll_init_map() in the following cases:
>>>>
>>>> 1) tc runs in batch mode.
>>>> 2) tc runs in monitor mode.
>>>> 3) tc dumps qdiscs/classes/filters for all netdev.
>>>>
>>>> This greatly reduces RTNL pressure on common operations.
>>>>
>>>> Signed-off-by: Eric Dumazet <edumazet@google.com>
>>
>> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
>>
> 
> Gentle reminder, this patch has not been merged.
> 
> I have other patches coming that depend on this one.
> 
> Thanks!

fixed the long line length and applied. please cc Jamal on all tc
patches; there is a MAINTAINERS file for iproute2 to indicate who needs
to be added to patches.

  reply	other threads:[~2026-05-02 18:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28  8:28 [PATCH iproute2-next] tc: use ll_init_map() only when needed Eric Dumazet
2026-04-30 15:36 ` David Ahern
2026-04-30 15:45   ` Jamal Hadi Salim
2026-04-30 18:20   ` Jamal Hadi Salim
2026-05-02 17:25     ` Eric Dumazet
2026-05-02 18:10       ` David Ahern [this message]
2026-05-03  7:45         ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63c0e51d-77cb-4b05-80a2-adebe3317cd5@kernel.org \
    --to=dsahern@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox