From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE7BB371043 for ; Tue, 10 Mar 2026 10:39:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773139151; cv=none; b=rzHqZKHp7et4rNNG2j7GrlaaxM8g4BFNVrTiuQFLhnM6QbzRvUqsw7DrzZfg6t3S+9C6i+5ThIfbqDMaofSHNLVOPNb67FUpHiZjhKFkVCWqO/8LQMOe3PSIoXntzGA1uygBi7g4AoLpQA8swdl3XApImCvDRI3x/adXvQJc9FA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773139151; c=relaxed/simple; bh=fP8O98OPBK3agQxFodoAANoQ6TaOINOYU8yt74cg8ks=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=e7CRgNgnp0gHw+CW+JVlbELetDopUnSpubedS8aKdtOTw+pW8Xj+FD6X/Xu4IK+vEmVuW3nmAMp9yY7JpJQHulNAhmxlpM7mbDKH3DJEE3XJWi/TNYEL8QzbVQJOi9AFw714D7VgYBDhnMH0quMrcnklXuQrsYLTlqMh0z3le9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GDwyEmHV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HK78/KAm; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GDwyEmHV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HK78/KAm" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A92Trf246825 for ; Tue, 10 Mar 2026 10:39:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yMz4jhDlfWwNY9iQLLZN7mOTPZWJN8ov+NL7HZ8hb6Y=; b=GDwyEmHV97sJBrPe BK8gPC2DDtSlLgq/QoSFFKMw1EVcCuBVse+71R6XtdhnKKaJAKEpBLyGvTXIWt7S yfGqMVWYvM0TKk2HVYUPrNd1zTkAnsZL4LHrasDeII429da4cC44EoMjnY57QfPI /Na8QKfK2NAB6gEMIDI+bmQph7NIPjLB7LdgtCmRnOJFiJV+xx8sbWkeP+5zhc7R mSW9JdawCYpMZxMMM6z8Ae7VwFIJJh2l8W0a5c5vlie5Qb7bfomhSZ9bGYQ9CnF2 /vu5qBsWqkITg3jNxV9Ivam+qGUGKQ08W66djPRYY4YUWGl/hv8e/aTDWYY+8pMg iw07EA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ct88021s3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 10:39:09 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cd7604c6a8so219177685a.2 for ; Tue, 10 Mar 2026 03:39:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773139148; x=1773743948; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yMz4jhDlfWwNY9iQLLZN7mOTPZWJN8ov+NL7HZ8hb6Y=; b=HK78/KAm70KdL+1edfDX8AN3kUonnnQfWuTKSnRqkkzriEqXKUIVM82T43b/6ulfT4 mV09F+viTJDvXt+Fh570D5v14UGWWw/vzg1bBS8zS9y0Tr6JjjRFntoUID8UWeo1Stcd JpIO+zSyPzfb48U4tQmu/EMlyJXJ0BD9L4dQHU0M1vfmIGk0WleGUDYjuhrjp3MrpaWx SrJdV2pLRztdfI4y6r69GaG2WaYtRcs+Xa0DI9URhKIzQUqiKBJVs/dIg/2+wQDdBHaZ nayMLC/qB4DzuzT0YxFb/WcnrVGTqrO9Zl2Z7JKjpXyXURZHJI/Cn7ix3wGib4p9HaKA 95Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773139148; x=1773743948; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yMz4jhDlfWwNY9iQLLZN7mOTPZWJN8ov+NL7HZ8hb6Y=; b=rylubUjUHWUTKaIyAA8ygrtU8/7EOYVKv2er7gu/jE/iZoaKPIXIMH1cGNxZAiWERU QABcJO0Y7qa7gyUPomGKQPv6W/jF9zDlmGLy9h5hMt/yGamRcocOlCdd146LG0jYCLQ1 G0nnFtSBZvP/jC2ZkrfiygvexBC71AxQzbP40kBvUVzuChtrQWAQMZxdym5KRavx9p9K Z/djGaUUdrvI1lv+xtr0IwO8OYV2yq6pMDrC9v508jvGIDo+GVZrbeDlu1H3FZzAfjVx seRG+o7vMiGTpPzVcgtPwIWC8jvILAMYpwpgtfrzCi3k7x0Ni5kJDDpg7QBIuKWxHmrH W+qA== X-Forwarded-Encrypted: i=1; AJvYcCXMKKVOXeQpjw91tNMHqqJH6LHJLbR1Am6A1g6tugGrIyymN9Jm6eLhmcWVywSaHozwNvwH49o=@vger.kernel.org X-Gm-Message-State: AOJu0YzR7qm4ddC5T6+jG4fqmgfIf8Piwkk8i5ofMg073ftLwV0cjTBC sqrWG+J+MPd5N9Fex8aiT3eTiyFw06iyk/QCFk5autqjDxTyMm6CDYuIQOMqV7xKPJvINZ1DE1z s1JKgiHjlxNxtcNz2VigNnHWYXvKZz90Tj14ZylEv6bog234q5ZRPlCExhbsWtodQ9aM= X-Gm-Gg: ATEYQzzo1OdB3lPKXF5E/wDdi57X7hg57rcLvSCCbac7zFXmS/ZYLe/fJX3VLFJlCIs XHKxP/dMx2UFa7UJ6en3cNEm50TNJuytcXcJtnVvzbQL0myv0Qv0AWNyXy5lQtumOErHgEEYpGo vKQ3UKsd4uklZkbQRc1JBJh752Dzotn2wek8J9zDPMI7KuNxJcNF2VYNivcWJSKWH6xhSscaDfd GYsW76O5pL72aCup/kNSklivVd8jDlo1Bs1SzJ501J1XUTIA0+sSnb3myVGjFy0o1YOGSEEwzoq eguWiHL6WbZlGAtQeyLZybOMZ2hXMVnEricunfHkqshuhZpL3/sPpUbRzKgdFduYU75D5AlxzwP porPQAHsFFXaISypcsjOIMz3uqanOIUi9Fox3u4kBdurfloHAGanB8mzsttOHhznYUJLqrFL7dj l5F1Q= X-Received: by 2002:a05:620a:8b17:b0:8cd:7fac:a2a6 with SMTP id af79cd13be357-8cd7faca57fmr608062785a.0.1773139147841; Tue, 10 Mar 2026 03:39:07 -0700 (PDT) X-Received: by 2002:a05:620a:8b17:b0:8cd:7fac:a2a6 with SMTP id af79cd13be357-8cd7faca57fmr608061285a.0.1773139147419; Tue, 10 Mar 2026 03:39:07 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b942ef4827esm460632666b.2.2026.03.10.03.39.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 03:39:06 -0700 (PDT) Message-ID: <63de1d04-adf0-4608-aeee-2d5208c100ae@oss.qualcomm.com> Date: Tue, 10 Mar 2026 11:39:03 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/7] arm64: dts: qcom: Add Monaco Monza SoM To: Srinivas Kandagatla , andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: richardcochran@gmail.com, geert+renesas@glider.be, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com, ebiggers@kernel.org, michal.simek@amd.com, luca.weiss@fairphone.com, sven@kernel.org, prabhakar.mahadev-lad.rj@bp.renesas.com, kuninori.morimoto.gx@renesas.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, m.facchin@arduino.cc, r.mereu@arduino.cc, loic.poulain@oss.qualcomm.com References: <20260309152420.1404349-1-srinivas.kandagatla@oss.qualcomm.com> <20260309152420.1404349-3-srinivas.kandagatla@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260309152420.1404349-3-srinivas.kandagatla@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDA5MCBTYWx0ZWRfXzh2DoxABY+sm ggqfZgSFtsyAo6agtGKhJrF4ZyDQ2PViCvEy+uIcyv3nVoFgmKPmofsqYESnL6nXz15PmCv8SPW WMpUk1BtZRzcGrkpyAyEgdiDREnD/ujjVK/xC3B9S5aPlshmizNO3sjWFxKNrMKe9MYSF/TQsQt ONIS8jzY8YWHNSsI+gGPBEPnMWjXrG5FuvUifyKY95y0n9Dbl4xDy0BgHKExZz8zpKDM8w6g3gI jJy3nSIg6axyjWmMm3ZfBW79I3fjVBmkldn9vWHlO4z9YOMH5i+5d5ZqIIGiG40dO6Bz81qAL0L lzzg6NySh85k/zkG4cPs7OVJMJwYx6jrP0kKJo/SC2sL+az7wXBfvH6b2zx0hyPXeQh2IsIrdPA hCxsisfpqxEmthGwb2gqnCDkYuehOZOxPvF7ohTE7eI1Tz89FsiAml+Ra7OyTJUbyJQwUU6Wjta QYuOpLfHGO0vfDTAtzg== X-Proofpoint-GUID: t2Op1i_5KJNLXUnP1uTgjHSbY2QFnWbg X-Authority-Analysis: v=2.4 cv=Jtf8bc4C c=1 sm=1 tr=0 ts=69aff4cd cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=eQA81Jyt6kpvTzy5W_wA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: t2Op1i_5KJNLXUnP1uTgjHSbY2QFnWbg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 malwarescore=0 priorityscore=1501 phishscore=0 impostorscore=0 bulkscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100090 On 3/9/26 4:24 PM, Srinivas Kandagatla wrote: > From: Loic Poulain > > The Monaco Monza SoM is a compact computing module that integrates a > Monaco/QCS8300 System on Chip (SoC), along with essential components > optimized for IoT applications. It is designed to be mounted on > carrier boards, enabling the development of complete embedded systems. > > The following components are described: > - Fixed S2S 1.8V rail > - PMM8654AU RPMh regulators (PMIC A and PMIC C) > - Display subsystem/phy supplies (DSI, DP) > - Enable GPU, GPI DMA, IRIS > - PCIe Gen4 for both controllers and PHY supply hookups > - QUPv3 firmware declarations > - REFGEN always-on workaround for USB2 HS PHY > - Remoteproc firmware names for ADSP, CDSP and GPDSP > - Ethernet SERDES supplies > - USB HS/SS PHY regulators > - On-SoM eMMC > > Signed-off-by: Loic Poulain > Co-developed-by: Srinivas Kandagatla > Signed-off-by: Srinivas Kandagatla > --- [...] > +/* PCIe0 Gen4 x2 */ > +&pcie0 { > + iommu-map = <0x0 &pcie_smmu 0x0000 0x1>, > + <0x100 &pcie_smmu 0x0001 0x1>, > + <0x200 &pcie_smmu 0x0007 0x1>, > + <0x208 &pcie_smmu 0x0002 0x1>, > + <0x210 &pcie_smmu 0x0003 0x1>, > + <0x218 &pcie_smmu 0x0004 0x1>, > + <0x300 &pcie_smmu 0x0005 0x1>, > + <0x400 &pcie_smmu 0x0006 0x1>; > + num-lanes = <2>; This is already set in monaco.dtsi [...] > +/* PCIe1 Gen4 x4 */ > +&pcie1 { > + num-lanes = <4>; likewise [...] > +&qupv3_id_0 { > + firmware-name = "qcom/qcs8300/qupv3fw.elf"; > + status = "okay"; Other nodes in this file have a \n before 'status', it'd be neat to have one everywhere > +}; > + > +&qupv3_id_1 { > + firmware-name = "qcom/qcs8300/qupv3fw.elf"; > + status = "okay"; > +}; > + > +/* There is a HW/FW issue preventing proper REFGEN hardware voting > + * for the USB2 HS PHY. As a workaround, we force REFGEN to stay > + * always‑on in software, matching initial bootloader config. > + */ > +&refgen{ Please add a space before '{' [...] > +/* OnSom eMMC */ > +&sdhc_1 { This one is out-of-place, alphabetically - please move it up Konrad