From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B400AC282C2 for ; Sun, 10 Feb 2019 14:24:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 74E21214DA for ; Sun, 10 Feb 2019 14:24:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kz0Vj06u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726154AbfBJOYo (ORCPT ); Sun, 10 Feb 2019 09:24:44 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:55875 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726042AbfBJOYo (ORCPT ); Sun, 10 Feb 2019 09:24:44 -0500 Received: by mail-wm1-f67.google.com with SMTP id r17so12307686wmh.5 for ; Sun, 10 Feb 2019 06:24:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=AbefILQFiZr6kZjWACAVbC/t0kqyIQgJhxdqGeIDwgg=; b=Kz0Vj06uG44zF3cIKRksbeaHGDcl+NZ3NLsa6415aRR09cZ5Ol9gU7IjNf606GuFbo yU4sVdvFpscrWdpe0OCEFOn9VO8m4fd1XyMKOrgU6N+SS0B8mtTngBI/kXyLYXrzUVkl +HGdh86pI5sPoNmL9++TbYGKoeyw0XNOOpm/ccdVGLaa7XRY2XL6iwnh4hokiri2e6xA D+12fFa2ww1peRfrohsOeyA1Z5orvkGTgBj3fRWRDKxLXh5qngWLgtki5XR40GyKlMyw 8KTSk3cAirpm/2nyyRKgg+njjq6dH4lBXJ5FlLxl0xo8BizZep4r7UGIaweX57ayoVQg hOMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=AbefILQFiZr6kZjWACAVbC/t0kqyIQgJhxdqGeIDwgg=; b=Ifr3szzdIH1DkmEN6PVbihHAhnp+wae74AqatVxeWhb1fWUYvcbMtZSTC90MdWSm6f rQyP3OB+5hSe8XykAnCkE4TA2W0SifNUjl/+HlugxdX8xXZ4nCSwX4+0h48fdiJpy4Fi gRo/OXGiw+y1Horrv+YUtAs5oXSx3dKRg3pOpZ0RApdNg4/nYjzF15L1yLF5SJXPX8Sj YkjQf83pbs2hpjTrFPyHDRgy91EU4ENcgiP9RNcCbZnEqMvKL+OiZ8yQuCoN7mW/vqX6 BSYiIF/uxn1RWz0kyem4WWmuE2P/WVlAOQ6YYpG0nYyXU3dRDHNHwLc1ROLjtf3ETFG1 qZ5g== X-Gm-Message-State: AHQUAuZcV6in6tPAainV314JLylx6moHF8yq6G/kkvmLIYFxLNjMN2eT AbG8sTBTtfJJT5biMFW9on0jCTpU X-Google-Smtp-Source: AHgI3IZzZzW43AK70BfoXUOng0/s0p9+9HvaeyiGnuGDkH0TgQjriqg7H74ScXyV6senvROUgpgBxg== X-Received: by 2002:adf:f08b:: with SMTP id n11mr8385744wro.182.1549808682022; Sun, 10 Feb 2019 06:24:42 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:1513:f24d:17d6:1a6d? (p200300EA8BF1E2001513F24D17D61A6D.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:1513:f24d:17d6:1a6d]) by smtp.googlemail.com with ESMTPSA id r14sm6051665wrv.77.2019.02.10.06.24.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Feb 2019 06:24:41 -0800 (PST) From: Heiner Kallweit Subject: [PATCH v2 net 0/2] r8169: revert two commits due to a regression To: Realtek linux nic maintainers , David Miller Cc: Sander Eikelenboom , "netdev@vger.kernel.org" Message-ID: <63e9e767-f78b-8865-fe25-41d77e4e7a58@gmail.com> Date: Sun, 10 Feb 2019 15:24:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sander reported a regression (kernel panic, see[1]), therefore let's revert these commits. Removal of the barriers doesn't seem to contribute to the issue, the patch just overlaps with the problematic one and only reverting both patches was tested. [1] https://marc.info/?t=154965066400001&r=1&w=2 v2: - improve commit message Heiner Kallweit (2): Revert "r8169: remove unneeded mmiowb barriers" Revert "r8169: make use of xmit_more and __netdev_sent_queue" drivers/net/ethernet/realtek/r8169.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) -- 2.20.1