From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: nick black <dankamongmen@gmail.com>, netdev@vger.kernel.org
Cc: Willem de Bruijn <willemb@google.com>
Subject: RE: [PATCH] [net] fix inaccuracies in msg_zerocopy.rst
Date: Fri, 24 Feb 2023 09:37:55 -0500 [thread overview]
Message-ID: <63f8cbc36988_78f6320819@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <Y/gg/EhIIjugLdd3@schwarzgerat.orthanc>
nick black wrote:
> Replace "sendpage" with "sendfile". Remove comment about
> ENOBUFS when the sockopt hasn't been set; experimentation
> indicates that this is not true.
>
> Signed-off-by: nick black <dankamongmen@gmail.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
The first error was there from the start. The second is an
inconsistency introduced with commit 5cf4a8532c99
("tcp: really ignore MSG_ZEROCOPY if no SO_ZEROCOPY")
If Documentation fixes go to net, I suggest that as Fixes tag.
next prev parent reply other threads:[~2023-02-24 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 2:29 [PATCH] [net] fix inaccuracies in msg_zerocopy.rst nick black
2023-02-24 14:37 ` Willem de Bruijn [this message]
2023-02-25 2:33 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63f8cbc36988_78f6320819@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=dankamongmen@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox