From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ED83C43381 for ; Wed, 27 Feb 2019 16:38:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 29C192186A for ; Wed, 27 Feb 2019 16:38:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726563AbfB0QiV (ORCPT ); Wed, 27 Feb 2019 11:38:21 -0500 Received: from www62.your-server.de ([213.133.104.62]:40254 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbfB0QiU (ORCPT ); Wed, 27 Feb 2019 11:38:20 -0500 Received: from [78.46.172.3] (helo=sslproxy06.your-server.de) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1gz2Dq-0002xF-Qs; Wed, 27 Feb 2019 17:38:18 +0100 Received: from [178.197.249.32] (helo=linux.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1gz2Dq-000G4O-Jh; Wed, 27 Feb 2019 17:38:18 +0100 Subject: Re: [PATCH V2] samples: bpf: fix: broken sample regarding removed function To: "Daniel T. Lee" , Alexei Starovoitov Cc: netdev@vger.kernel.org References: <20190227075226.4409-1-danieltimlee@gmail.com> From: Daniel Borkmann Message-ID: <63f9b3e9-e14d-8ca2-d679-11aac2e4ac8d@iogearbox.net> Date: Wed, 27 Feb 2019 17:38:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20190227075226.4409-1-danieltimlee@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.2/25373/Wed Feb 27 11:36:59 2019) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 02/27/2019 08:52 AM, Daniel T. Lee wrote: > Currently, running sample "task_fd_query" and "tracex3" occurs the > following error. On kernel v5.0-rc* this sample will be unavailable > due to the removal of function 'blk_start_request' at commit "a1ce35f". > (function removed, as "Single Queue IO scheduler" no longer exists) > > $ sudo ./task_fd_query > failed to create kprobe 'blk_start_request' error 'No such file or > directory' > > This commit will change the function 'blk_start_request' to > 'blk_mq_start_request' to fix the broken sample. > > Signed-off-by: Daniel T. Lee Applied, thanks! (Also please make sure to test your changes in future ahead of submission to save valuable reviewer time.)