From: Paolo Abeni <pabeni@redhat.com>
To: Li Xiasong <lixiasong1@huawei.com>,
matttbe@kernel.org, martineau@kernel.org, geliang@kernel.org,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
horms@kernel.org
Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev,
linux-kernel@vger.kernel.org, weiyongjun1@huawei.com,
yuehaibing@huawei.com, zhangchangzhong@huawei.com
Subject: Re: [PATCH net] mptcp: fix soft lockup in mptcp_recvmsg()
Date: Wed, 4 Mar 2026 10:07:02 +0100 [thread overview]
Message-ID: <64132462-e640-4ea6-82e8-48ca07a6ad44@redhat.com> (raw)
In-Reply-To: <20260302052651.1466983-1-lixiasong1@huawei.com>
On 3/2/26 6:26 AM, Li Xiasong wrote:
> @@ -2343,7 +2347,7 @@ static int mptcp_recvmsg(struct sock *sk, struct msghdr *msg, size_t len,
>
> pr_debug("block timeout %ld\n", timeo);
> mptcp_cleanup_rbuf(msk, copied);
> - err = sk_wait_data(sk, &timeo, NULL);
> + err = sk_wait_data(sk, &timeo, last);
Isn't
err = sk_wait_data(sk, &timeo, skb_peek_tail(&sk->sk_receive_queue));
Enough?
Also, could you please add a paired tests-case? Thanks!
Paolo
next prev parent reply other threads:[~2026-03-04 9:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 5:26 [PATCH net] mptcp: fix soft lockup in mptcp_recvmsg() Li Xiasong
2026-03-03 11:08 ` Matthieu Baerts
2026-03-03 18:06 ` Matthieu Baerts
2026-03-04 9:24 ` Li Xiasong
2026-03-23 11:19 ` Matthieu Baerts
2026-03-04 9:07 ` Paolo Abeni [this message]
2026-03-04 11:33 ` Li Xiasong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64132462-e640-4ea6-82e8-48ca07a6ad44@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixiasong1@huawei.com \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox