From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ka-Cheong Poon Subject: Re: [PATCH v2 net-next 1/3] rds: Changing IP address internal representation to struct in6_addr Date: Fri, 6 Jul 2018 23:08:04 +0800 Message-ID: <64196e9e-bb90-9452-5fbf-2004e2bd68e3@oracle.com> References: <693463ed87c5956eed05a6266c4edf354ab3d51a.1530086216.git.ka-cheong.poon@oracle.com> <6a7b0951-d950-1555-a5b2-622d6f7b9f8f@oracle.com> <20180706101505.GA32098@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, rds-devel@oss.oracle.com To: Sowmini Varadhan , Santosh Shilimkar , davem@davemloft.net Return-path: Received: from userp2130.oracle.com ([156.151.31.86]:40792 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932345AbeGFPLQ (ORCPT ); Fri, 6 Jul 2018 11:11:16 -0400 In-Reply-To: <20180706101505.GA32098@oracle.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 07/06/2018 06:15 PM, Sowmini Varadhan wrote: > On (07/06/18 17:08), Ka-Cheong Poon wrote: >>> Hmm. Why do you need to include tcp header in ib transport >>> code ? If there is any common function just move to core >>> common file and use it. >> >> I think it can be removed as it is left over from earlier >> changes when the IB IPv6 listener port was RDS_TCP_PORT. >> Now all the port definitions are in rds.h. > > Transport specific information such as port numbers should not > be smeared into the common rds-module. Please fix that. > > If IB is also piggybacking on port 16385 (why?), please use your > own definitions for it in IB specific header files. As mentioned in a previous mail, it is unclear why the port number is transport specific. Most Internet services use the same port number running over TCP/UDP as shown in the IANA database. And the IANA RDS registration is the same. What is the rationale of having a transport specific number in the RDS implementation? -- K. Poon ka-cheong.poon@oracle.com