From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Yang Yang <yang.yang29@zte.com.cn>,
davem@davemloft.net, edumazet@google.com,
willemdebruijn.kernel@gmail.com
Cc: yang.yang29@zte.com.cn, kuba@kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com, shuah@kernel.org,
zhang.yunkai@zte.com.cn, xu.xin16@zte.com.cn,
Xuexin Jiang <jiang.xuexin@zte.com.cn>
Subject: RE: [PATCH linux-next 1/3] selftests: net: udpgso_bench_rx: Fix verifty exceptions
Date: Mon, 17 Apr 2023 11:16:02 -0400 [thread overview]
Message-ID: <643d62b28e413_29adc929416@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <20230417122423.193237-1-yang.yang29@zte.com.cn>
Yang Yang wrote:
> From: Zhang Yunkai (CGEL ZTE) <zhang.yunkai@zte.com.cn>
>
> The verification function of this test case is likely to encounter the
> following error, which may confuse users.
>
> Executing the following command fails:
> bash# udpgso_bench_tx -l 4 -4 -D "$DST"
> bash# udpgso_bench_tx -l 4 -4 -D "$DST" -S 0
> bash# udpgso_bench_rx -4 -G -S 1472 -v
Why are you running two senders concurrently? The test is not intended
to handle that case.
> udpgso_bench_rx: data[1472]: len 2944, a(97) != q(113)
>
> This is because the sending buffers are not aligned by 26 bytes, and the
> GRO is not merged sequentially, and the receiver does not judge this
> situation. We do the validation after the data is split at the receiving
> end, just as the application actually uses this feature.
>
> Signed-off-by: Zhang Yunkai (CGEL ZTE) <zhang.yunkai@zte.com.cn>
> Reviewed-by: xu xin (CGEL ZTE) <xu.xin16@zte.com.cn>
> Reviewed-by: Yang Yang (CGEL ZTE) <yang.yang29@zte.com.cn>
> Cc: Xuexin Jiang (CGEL ZTE) <jiang.xuexin@zte.com.cn>
next prev parent reply other threads:[~2023-04-17 15:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 12:17 [PATCH linux-next 0/3] selftests: net: udpgso_bench_rx: Fix verifty, gsosize, and packet number exceptions yang.yang29
2023-04-17 12:24 ` [PATCH linux-next 1/3] selftests: net: udpgso_bench_rx: Fix verifty exceptions Yang Yang
2023-04-17 15:16 ` Willem de Bruijn [this message]
2023-04-18 1:29 ` Yang Yang
2023-04-18 13:01 ` Willem de Bruijn
2023-04-18 14:20 ` Paolo Abeni
2023-04-17 12:24 ` [PATCH linux-next 2/3] selftests: net: udpgso_bench_rx: Fix gsosize exceptions Yang Yang
2023-04-17 12:25 ` [PATCH linux-next 3/3] selftests: net: udpgso_bench_rx: Fix packet number exceptions Yang Yang
2023-04-17 15:27 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=643d62b28e413_29adc929416@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiang.xuexin@zte.com.cn \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=xu.xin16@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
--cc=zhang.yunkai@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox