From: "Michal Vokáč" <vokac.m@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org
Cc: michal.vokac@ysoft.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, vivien.didelot@savoirfairelinux.com,
andrew@lunn.ch, mark.rutland@arm.com, robh+dt@kernel.org,
davem@davemloft.net
Subject: Re: [PATCH net-next 4/7] net: dsa: qca8k: Force CPU port to its highest bandwidth
Date: Tue, 22 May 2018 07:30:03 +0200 [thread overview]
Message-ID: <64573982-6ab3-c92d-bc24-5e27d70b89ce@gmail.com> (raw)
In-Reply-To: <7d73f1b8-453a-fcbe-a1b8-41ced652deb0@gmail.com>
On 21.5.2018 17:19, Florian Fainelli wrote:
>
> On 05/21/2018 06:28 AM, Michal Vokáč wrote:
>> By default autonegotiation is enabled to configure MAC on all ports.
>> For the CPU port autonegotiation can not be used so we need to set
>> some sensible defaults manually.
>>
>> This patch forces the default setting of the CPU port to 1000Mbps/full
>> duplex which is the chip maximum capability.
>>
>> Also correct size of the bit field used to configure link speed.
>>
>> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>
> Likewise, would not we want to have a:
>
> Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family")
>
> tag here as well?
Good point, I will add this in v2.
Thanks,
Michal
next prev parent reply other threads:[~2018-05-22 5:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 13:28 [PATCH net-next 0/7] Add support for QCA8334 switch Michal Vokáč
2018-05-21 13:28 ` [PATCH net-next 1/7] net: dsa: qca8k: Add QCA8334 binding documentation Michal Vokáč
2018-05-21 14:39 ` Andrew Lunn
2018-05-21 14:47 ` Andrew Lunn
2018-05-22 5:16 ` Michal Vokáč
2018-05-21 13:28 ` [PATCH net-next 2/7] net: dsa: qca8k: Add support for QCA8334 switch Michal Vokáč
2018-05-21 13:28 ` [PATCH net-next 3/7] net: dsa: qca8k: Enable RXMAC when bringing up a port Michal Vokáč
2018-05-21 14:40 ` Andrew Lunn
2018-05-21 15:17 ` Florian Fainelli
2018-05-22 5:28 ` Michal Vokáč
2018-05-21 13:28 ` [PATCH net-next 4/7] net: dsa: qca8k: Force CPU port to its highest bandwidth Michal Vokáč
2018-05-21 14:42 ` Andrew Lunn
2018-05-21 15:19 ` Florian Fainelli
2018-05-22 5:30 ` Michal Vokáč [this message]
2018-05-21 13:28 ` [PATCH net-next 5/7] net: dsa: qca8k: Allow overwriting CPU port setting Michal Vokáč
2018-05-21 14:46 ` Andrew Lunn
2018-05-21 15:20 ` Florian Fainelli
2018-05-21 13:28 ` [PATCH net-next 6/7] net: dsa: qca8k: Replace GPL boilerplate by SPDX Michal Vokáč
2018-05-21 14:47 ` Andrew Lunn
2018-05-21 15:20 ` Florian Fainelli
2018-05-22 5:49 ` Michal Vokáč
2018-05-21 13:28 ` [PATCH net-next 7/7] net: dsa: qca8k: Remove rudundant parentheses Michal Vokáč
2018-05-21 14:48 ` Andrew Lunn
2018-05-21 15:21 ` Florian Fainelli
2018-05-22 5:52 ` Michal Vokáč
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64573982-6ab3-c92d-bc24-5e27d70b89ce@gmail.com \
--to=vokac.m@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.vokac@ysoft.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).