From: Alexandra Winter <wintera@linux.ibm.com>
To: Simon Horman <simon.horman@corigine.com>,
patchwork-bot+netdevbpf@kernel.org
Cc: Xuezhi Zhang <zhangxuezhi3@gmail.com>,
zhangxuezhi1@coolpad.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
svens@linux.ibm.com, linux-s390@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/qeth: convert sysfs snprintf to sysfs_emit
Date: Thu, 5 Jan 2023 13:17:26 +0100 [thread overview]
Message-ID: <645e311c-9aca-b42d-c13c-b4365635e4c2@linux.ibm.com> (raw)
In-Reply-To: <Y7a8OaOnQtRmGLIu@corigine.com>
On 05.01.23 13:02, Simon Horman wrote:
> On Wed, Dec 28, 2022 at 12:20:15PM +0000, patchwork-bot+netdevbpf@kernel.org wrote:
>> Hello:
>>
>> This patch was applied to netdev/net.git (master)
>> by David S. Miller <davem@davemloft.net>:
>>
>> On Tue, 27 Dec 2022 19:03:52 +0800 you wrote:
>>> From: Xuezhi Zhang <zhangxuezhi1@coolpad.com>
>>>
>>> Follow the advice of the Documentation/filesystems/sysfs.rst
>>> and show() should only use sysfs_emit() or sysfs_emit_at()
>>> when formatting the value to be returned to user space.
>>>
>>> Signed-off-by: Xuezhi Zhang <zhangxuezhi1@coolpad.com>
>>>
>>> [...]
>>
>> Here is the summary with links:
>> - s390/qeth: convert sysfs snprintf to sysfs_emit
>> https://git.kernel.org/netdev/net/c/c2052189f19b
>
> I'm a little late to the party here, but should the use of sprintf() in
> show functions elsewhere in the qeth_core_sys.c also be updated?
>
Yes, we are working on this. Several patches will come soon, that cleanup whole files.
No need to send additional small patches on this topic at the moment.
next prev parent reply other threads:[~2023-01-05 12:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 11:03 [PATCH] s390/qeth: convert sysfs snprintf to sysfs_emit Xuezhi Zhang
2022-12-28 12:20 ` patchwork-bot+netdevbpf
2023-01-05 12:02 ` Simon Horman
2023-01-05 12:17 ` Alexandra Winter [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-12-27 11:03 Xuezhi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=645e311c-9aca-b42d-c13c-b4365635e4c2@linux.ibm.com \
--to=wintera@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=patchwork-bot+netdevbpf@kernel.org \
--cc=simon.horman@corigine.com \
--cc=svens@linux.ibm.com \
--cc=zhangxuezhi1@coolpad.com \
--cc=zhangxuezhi3@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).