From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH net-next 1/2] rds: rds_ib_recv_alloc_cache() should call alloc_percpu_gfp() instead Date: Tue, 31 Jul 2018 10:35:14 -0700 Message-ID: <64708338-a9ba-4f57-3c24-ecee30498a0c@oracle.com> References: <1533016122-12654-1-git-send-email-ka-cheong.poon@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, rds-devel@oss.oracle.com To: Ka-Cheong Poon , netdev@vger.kernel.org Return-path: Received: from userp2130.oracle.com ([156.151.31.86]:41090 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728327AbeGaTQm (ORCPT ); Tue, 31 Jul 2018 15:16:42 -0400 In-Reply-To: <1533016122-12654-1-git-send-email-ka-cheong.poon@oracle.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 7/30/2018 10:48 PM, Ka-Cheong Poon wrote: > Currently, rds_ib_conn_alloc() calls rds_ib_recv_alloc_caches() > without passing along the gfp_t flag. But rds_ib_recv_alloc_caches() > and rds_ib_recv_alloc_cache() should take a gfp_t parameter so that > rds_ib_recv_alloc_cache() can call alloc_percpu_gfp() using the > correct flag instead of calling alloc_percpu(). > > Signed-off-by: Ka-Cheong Poon > --- Looks good !! Acked-by: Santosh Shilimkar