From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 262EEC43381 for ; Wed, 27 Mar 2019 19:54:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E75AB2075C for ; Wed, 27 Mar 2019 19:54:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="llJKnsaQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728556AbfC0Tyw (ORCPT ); Wed, 27 Mar 2019 15:54:52 -0400 Received: from mail-pf1-f175.google.com ([209.85.210.175]:38521 "EHLO mail-pf1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727446AbfC0Tyw (ORCPT ); Wed, 27 Mar 2019 15:54:52 -0400 Received: by mail-pf1-f175.google.com with SMTP id 10so10206204pfo.5 for ; Wed, 27 Mar 2019 12:54:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8SbuzFWeH2uiilF1rPE5tu2J8+UoonPiLVOopbRgR9o=; b=llJKnsaQgwRy3ldgUfhqYeId/jyoHeq9oHN2DDhexlLo4XO2X1hTlZL6ZknEVKY6Gs 5ql0dS3BGlpCzYR6SvnxDOcFhMBPdf5o/FAsLhmoVCDENZFEA3XY/36f0wSTKib+jrYi V4Nvi7Xcvo60ymeyRQxpJFTa1XDeMoBzeWAioFIEiUB6dFYXn11SbOPEQG/zEzKFsESK s4G7Ye5Xw3VL7kwnz7K6COuFiBJTMdN7bL6piog/KIUUN987NrmmteZAVkVGvy7qa5Uy wJEaEcXxnEjVj2T+IsJGgnG0Dah234CwgurfAYA9wYvmUncHjQ44p0+AU9WRVDsd9oMe NFbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8SbuzFWeH2uiilF1rPE5tu2J8+UoonPiLVOopbRgR9o=; b=KAJ6FECSbQ+xm5VIVC5lhISWpEn8R+0n0FB7UfAJE9iBqpaNbxlUh8KhROGVL9S3lS ufHv9fwm5qYHyllHCbtkW6NXoNZ0tG4ouAx281EXTL6COU2T1p4GER10rvGEjXuEhAtQ y5NIxQ+7f89g9duMxN6wk5H9HhUECIFrJghK5agdU30CYUKwW/wY0N8hi4aLgvu5hScI 4EPzYtosAbNH1186GmB6s8znHM5Y/1koUxj/8yImlParYM3FzsI2cx4hxeE+egqTQzvE r++8wJuwrhyJ0yIuauBbX9DzM/vr/i7aYy7SCDJChex75ARGB+o1SmocvtkWVy9Li95l AtiQ== X-Gm-Message-State: APjAAAUTh91nm6qhQ27fl7L2I+/AZygA6NSpbV0+4tyTkmHXli1G2AV/ WV8ElXaZckHr0amADcgB1q4= X-Google-Smtp-Source: APXvYqzGr6Ck1ykgDI26eSyMwXK368ixhCyBFx83BVyKLIB5eCssge9G0JwmlDxS5RgkDyF+6sG+Tw== X-Received: by 2002:a63:f212:: with SMTP id v18mr15259656pgh.231.1553716491058; Wed, 27 Mar 2019 12:54:51 -0700 (PDT) Received: from [10.69.78.41] ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id l86sm9984215pfj.162.2019.03.27.12.54.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 12:54:50 -0700 (PDT) Subject: Re: [patch net-next v2 08/12] dsa: implement ndo_get_devlink_port To: Jiri Pirko , netdev@vger.kernel.org Cc: davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, andrew@lunn.ch, vivien.didelot@gmail.com, michael.chan@broadcom.com References: <20190326120307.2953-1-jiri@resnulli.us> <20190326120307.2953-9-jiri@resnulli.us> From: Florian Fainelli Openpgp: preference=signencrypt Message-ID: <6477e604-0b6a-fa49-920f-9a1fd4478dbb@gmail.com> Date: Wed, 27 Mar 2019 12:54:41 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190326120307.2953-9-jiri@resnulli.us> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/26/2019 5:03 AM, Jiri Pirko wrote: > From: Jiri Pirko > > In order for devlink compat functions to work, implement > ndo_get_devlink_port. Legacy slaves does not have devlink port instances > created for themselves. Not a big fan of de-duplicating the entire set of netdev_ops for legacy vs. non-legacy, can we just check that the devlink instance was r -- Florian