From: Paolo Abeni <pabeni@redhat.com>
To: chia-yu.chang@nokia-bell-labs.com, edumazet@google.com,
parav@nvidia.com, linux-doc@vger.kernel.org, corbet@lwn.net,
horms@kernel.org, dsahern@kernel.org, kuniyu@google.com,
bpf@vger.kernel.org, netdev@vger.kernel.org, dave.taht@gmail.com,
jhs@mojatatu.com, kuba@kernel.org, stephen@networkplumber.org,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
andrew+netdev@lunn.ch, donald.hunter@gmail.com, ast@fiberby.net,
liuhangbin@gmail.com, shuah@kernel.org,
linux-kselftest@vger.kernel.org, ij@kernel.org,
ncardwell@google.com, koen.de_schepper@nokia-bell-labs.com,
g.white@cablelabs.com, ingemar.s.johansson@ericsson.com,
mirja.kuehlewind@ericsson.com, cheshire@apple.com,
rs.ietf@gmx.at, Jason_Livingood@comcast.com,
vidhi_goel@apple.com
Subject: Re: [PATCH v7 net-next 10/13] tcp: accecn: unset ECT if receive or send ACE=0 in AccECN negotiaion
Date: Thu, 8 Jan 2026 09:34:46 +0100 [thread overview]
Message-ID: <6491258b-0ef5-4789-b856-3e9cd9a3fbd5@redhat.com> (raw)
In-Reply-To: <20260103131028.10708-11-chia-yu.chang@nokia-bell-labs.com>
On 1/3/26 2:10 PM, chia-yu.chang@nokia-bell-labs.com wrote:
> @@ -1103,6 +1104,9 @@ static void reqsk_timer_handler(struct timer_list *t)
> (!resend ||
> !tcp_rtx_synack(sk_listener, req) ||
> inet_rsk(req)->acked)) {
> + if (req->num_retrans > 1 && tcp_rsk(req)->accecn_ok)
> + tcp_accecn_fail_mode_set(tcp_sk(sk_listener),
> + TCP_ACCECN_ACE_FAIL_SEND);
Minor nit: AFAICS the above block is repeated 3 times and could deserve
landing in it's own helper.
/P
next prev parent reply other threads:[~2026-01-08 8:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-03 13:10 [PATCH v7 net-next 00/13] AccECN protocol case handling series chia-yu.chang
2026-01-03 13:10 ` [PATCH v7 net-next 01/13] tcp: try to avoid safer when ACKs are thinned chia-yu.chang
2026-01-03 13:10 ` [PATCH v7 net-next 02/13] gro: flushing when CWR is set negatively affects AccECN chia-yu.chang
2026-01-03 13:10 ` [PATCH v7 net-next 03/13] selftests/net: gro: add self-test for TCP CWR flag chia-yu.chang
2026-01-03 13:10 ` [PATCH v7 net-next 04/13] tcp: ECT_1_NEGOTIATION and NEEDS_ACCECN identifiers chia-yu.chang
2026-01-03 13:10 ` [PATCH v7 net-next 05/13] tcp: disable RFC3168 fallback identifier for CC modules chia-yu.chang
2026-01-03 13:10 ` [PATCH v7 net-next 06/13] tcp: accecn: handle unexpected AccECN negotiation feedback chia-yu.chang
2026-01-03 13:10 ` [PATCH v7 net-next 07/13] tcp: accecn: retransmit downgraded SYN in AccECN negotiation chia-yu.chang
2026-01-03 13:10 ` [PATCH v7 net-next 08/13] tcp: add TCP_SYNACK_RETRANS synack_type chia-yu.chang
2026-01-03 13:10 ` [PATCH v7 net-next 09/13] tcp: accecn: retransmit SYN/ACK without AccECN option or non-AccECN SYN/ACK chia-yu.chang
2026-01-03 13:10 ` [PATCH v7 net-next 10/13] tcp: accecn: unset ECT if receive or send ACE=0 in AccECN negotiaion chia-yu.chang
2026-01-08 8:34 ` Paolo Abeni [this message]
2026-01-03 13:10 ` [PATCH v7 net-next 11/13] tcp: accecn: fallback outgoing half link to non-AccECN chia-yu.chang
2026-01-03 13:10 ` [PATCH v7 net-next 12/13] tcp: accecn: detect loss ACK w/ AccECN option and add TCP_ACCECN_OPTION_PERSIST chia-yu.chang
2026-01-03 13:10 ` [PATCH v7 net-next 13/13] tcp: accecn: enable AccECN chia-yu.chang
2026-01-08 8:41 ` [PATCH v7 net-next 00/13] AccECN protocol case handling series Paolo Abeni
2026-01-08 8:47 ` Chia-Yu Chang (Nokia)
2026-01-08 12:05 ` Paolo Abeni
2026-01-08 12:18 ` Eric Dumazet
2026-01-08 16:01 ` Chia-Yu Chang (Nokia)
2026-01-13 8:07 ` Paolo Abeni
-- strict thread matches above, loose matches on Subject: below --
2025-12-01 16:37 chia-yu.chang
2025-12-01 16:37 ` [PATCH v7 net-next 10/13] tcp: accecn: unset ECT if receive or send ACE=0 in AccECN negotiaion chia-yu.chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6491258b-0ef5-4789-b856-3e9cd9a3fbd5@redhat.com \
--to=pabeni@redhat.com \
--cc=Jason_Livingood@comcast.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@fiberby.net \
--cc=bpf@vger.kernel.org \
--cc=cheshire@apple.com \
--cc=chia-yu.chang@nokia-bell-labs.com \
--cc=corbet@lwn.net \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=g.white@cablelabs.com \
--cc=horms@kernel.org \
--cc=ij@kernel.org \
--cc=ingemar.s.johansson@ericsson.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=koen.de_schepper@nokia-bell-labs.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=mirja.kuehlewind@ericsson.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=rs.ietf@gmx.at \
--cc=shuah@kernel.org \
--cc=stephen@networkplumber.org \
--cc=vidhi_goel@apple.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox