From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9453C4321E for ; Sun, 4 Dec 2022 18:52:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230177AbiLDSwt (ORCPT ); Sun, 4 Dec 2022 13:52:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230142AbiLDSwq (ORCPT ); Sun, 4 Dec 2022 13:52:46 -0500 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBFEF636A; Sun, 4 Dec 2022 10:52:44 -0800 (PST) Received: by mail-ej1-x636.google.com with SMTP id b2so23020987eja.7; Sun, 04 Dec 2022 10:52:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rVa4SBMWf0cJk973qfgmDDD5XVUgzDvkwfsTpMSYivQ=; b=CUKaXErfIsP67bFO/VqI2crHhKyX6YmMOE1PKmCgRdEUaZqHUsmeW/WQdBVzF25lvd FlfXhVb+DNKUaRfjDvml1dna7L4CTTUNZzaVTceLZ7OiHLSF0lYN09poBg4fo4N+PlTW JMsalZ830SiPX477zBmT3sMOU3h0UmH6tZbLJAT2iDtIKEn+utNnbH0JeGtaMuzxsHOu UVOQk/Ey7yTmU3uDvRpWpPr2Gf2/yPbC8oFsMUK6PYnnZ4iylG0AwqCsiKYnvvXtJhhD eNBOgVSbniCqXQbmqLZaXneyoczPE3sA/jEmftGicbM6kMlhoyg/CxXyYj0sZp/r21l0 5mGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rVa4SBMWf0cJk973qfgmDDD5XVUgzDvkwfsTpMSYivQ=; b=3IdEYMuMAc6JXCh61b5nz7sMzkZ9DT9bq/V34Yb4ZtwJRiZLxxCvs0ppUaTSroV7RN TTxoyCm4mWuzpmjeJJaB7MBR+240/zqkHDYIdlgl2EWPHQj5nb10f8bL4IOMvp8pvdG+ d556bd4yzMtBSC/A4eJvoNb/SdM42pyyph42FxSy+i1GcDXQx3wZ88CMRymZokO2VBhl m8T4ju8GnKV4Hdd2agSWERYo1neiYNDgtlLpORuG5e5aAHHc0quyhniHyzC61jCbt33+ 7yxddkjCXoiTSSwzQe5jtIZj0VY42IFFG3XdRZm27JdV1TOSyA62ZmSwdALlVIclpLL6 12mw== X-Gm-Message-State: ANoB5pmUdDJ/65dL6acHsLGKknFjsNRx9P0tP0lM2dtjSDJclWyggTWp gHHntkqrw5//xzZEpfcu4qc= X-Google-Smtp-Source: AA0mqf55UyAUjqtIhhPbAj06nf+q+dxwAswo2zKiXaK4oZA9xv1RSCwv6Ru1aDgJhZv8q2pvkSo4RA== X-Received: by 2002:a17:907:a0ca:b0:7c0:b4bc:eed3 with SMTP id hw10-20020a170907a0ca00b007c0b4bceed3mr12331981ejc.735.1670179963240; Sun, 04 Dec 2022 10:52:43 -0800 (PST) Received: from [192.168.1.101] ([37.252.91.128]) by smtp.gmail.com with ESMTPSA id i9-20020a170906698900b007bff9fb211fsm5408674ejr.57.2022.12.04.10.52.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Dec 2022 10:52:42 -0800 (PST) Message-ID: <64aada78-8029-1b05-b802-a005549503c9@gmail.com> Date: Sun, 4 Dec 2022 22:52:38 +0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH net-next v1 01/13] net: wwan: tmi: Add PCIe core Content-Language: en-US To: Yanchao Yang Cc: Loic Poulain , Johannes Berg , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev ML , kernel ML , MTK ML , Liang Lu , Haijun Liu , Hua Yang , Ting Wang , Felix Chen , Mingliang Xu , Min Dong , Aiden Wang , Guohao Zhang , Chris Feng , Lambert Wang , Mingchuang Qiao , Xiayu Zhang , Haozhe Chang , MediaTek Corporation References: <20221122111152.160377-1-yanchao.yang@mediatek.com> <20221122111152.160377-2-yanchao.yang@mediatek.com> From: Sergey Ryazanov In-Reply-To: <20221122111152.160377-2-yanchao.yang@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello Yanchao, On 22.11.2022 15:11, Yanchao Yang wrote: > From: MediaTek Corporation > > Registers the TMI device driver with the kernel. Set up all the fundamental > configurations for the device: PCIe layer, Modem Host Cross Core Interface > (MHCCIF), Reset Generation Unit (RGU), modem common control operations and > build infrastructure. > > * PCIe layer code implements driver probe and removal, MSI-X interrupt > initialization and de-initialization, and the way of resetting the device. > * MHCCIF provides interrupt channels to communicate events such as handshake, > PM and port enumeration. > * RGU provides interrupt channels to generate notifications from the device > so that the TMI driver could get the device reset. > * Modem common control operations provide the basic read/write functions of > the device's hardware registers, mask/unmask/get/clear functions of the > device's interrupt registers and inquiry functions of the device's status. > > Signed-off-by: Ting Wang > Signed-off-by: MediaTek Corporation > --- > drivers/net/wwan/Kconfig | 11 + > drivers/net/wwan/Makefile | 1 + > drivers/net/wwan/mediatek/Makefile | 12 + > drivers/net/wwan/mediatek/mtk_common.h | 30 + > drivers/net/wwan/mediatek/mtk_dev.c | 50 + > drivers/net/wwan/mediatek/mtk_dev.h | 503 ++++++++++ > drivers/net/wwan/mediatek/pcie/mtk_pci.c | 1164 ++++++++++++++++++++++ > drivers/net/wwan/mediatek/pcie/mtk_pci.h | 150 +++ > drivers/net/wwan/mediatek/pcie/mtk_reg.h | 69 ++ > 9 files changed, 1990 insertions(+) > create mode 100644 drivers/net/wwan/mediatek/Makefile > create mode 100644 drivers/net/wwan/mediatek/mtk_common.h > create mode 100644 drivers/net/wwan/mediatek/mtk_dev.c > create mode 100644 drivers/net/wwan/mediatek/mtk_dev.h > create mode 100644 drivers/net/wwan/mediatek/pcie/mtk_pci.c > create mode 100644 drivers/net/wwan/mediatek/pcie/mtk_pci.h > create mode 100644 drivers/net/wwan/mediatek/pcie/mtk_reg.h > > diff --git a/drivers/net/wwan/Kconfig b/drivers/net/wwan/Kconfig > index 3486ffe94ac4..a93a0c511d50 100644 > --- a/drivers/net/wwan/Kconfig > +++ b/drivers/net/wwan/Kconfig > @@ -119,6 +119,17 @@ config MTK_T7XX > > If unsure, say N. > > +config MTK_TMI > + tristate "TMI Driver for Mediatek T-series Device" > + depends on PCI > + help > + This driver enables Mediatek T-series WWAN Device communication. > + > + If you have one of those Mediatek T-series WWAN Modules and wish to > + use it in Linux say Y/M here. From this and the series descriptions, it is unclear which modem chips this driver is intended for and how does it correlate with the T7xx driver? Is the TMI driver a drop-in replacement for the t7xx driver, or does the TMI driver support any T-series chips except t7xx? > + > + If unsure, say N. > + > endif # WWAN > > endmenu > diff --git a/drivers/net/wwan/Makefile b/drivers/net/wwan/Makefile > index 3960c0ae2445..198d8074851f 100644 > --- a/drivers/net/wwan/Makefile > +++ b/drivers/net/wwan/Makefile > @@ -14,3 +14,4 @@ obj-$(CONFIG_QCOM_BAM_DMUX) += qcom_bam_dmux.o > obj-$(CONFIG_RPMSG_WWAN_CTRL) += rpmsg_wwan_ctrl.o > obj-$(CONFIG_IOSM) += iosm/ > obj-$(CONFIG_MTK_T7XX) += t7xx/ > +obj-$(CONFIG_MTK_TMI) += mediatek/ The driver is called mtk_tmi, but its code is placed to the directory with too generic name 'mediatek'. Do you plan too keep all possible future drivers in this directory? -- Sergey