From: Johannes Berg <johannes@sipsolutions.net>
To: Chris Chiu <chris.chiu@canonical.com>
Cc: Jes.Sorensen@gmail.com, kvalo@codeaurora.org,
davem@davemloft.net, kuba@kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>,
code@reto-schneider.ch
Subject: Re: [PATCH v2 1/2] rtl8xxxu: unset the hw capability HAS_RATE_CONTROL
Date: Fri, 13 Aug 2021 10:26:24 +0200 [thread overview]
Message-ID: <64b3313ec8a15229e75a29fac2fb5ba1491a2191.camel@sipsolutions.net> (raw)
In-Reply-To: <CABTNMG0Q6Oh8T_sqW-b3ymdbepYmMRQALGozo6pXiKg=r-ndxA@mail.gmail.com>
On Fri, 2021-06-11 at 22:47 +0800, Chris Chiu wrote:
>
> Based on the description in
> https://github.com/torvalds/linux/blob/master/net/mac80211/agg-tx.c#L32
> to L36, if we set HAS_RATE_CONTROL, which means we don't want the
> software rate control (default minstrel), then we will have to deal
> with both the rate control and the TX aggregation in the driver, and
> the .ampdu_action is not really required.
>
I don't think this is true. You'll probably still want to use the A-MPDU
state machine in mac80211, etc.
What you *don't* get without rate control in mac80211 is any decision on
whether or not to enable A-MPDU, but that's something you can easily do
elsewhere and just call ieee80211_start_tx_ba_session() at an
appropriate point in time.
johannes
next prev parent reply other threads:[~2021-08-13 8:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 12:06 [PATCH v2 0/2] Make ampdu tx work correctly chris.chiu
2021-06-03 12:06 ` [PATCH v2 1/2] rtl8xxxu: unset the hw capability HAS_RATE_CONTROL chris.chiu
2021-06-10 20:18 ` Johannes Berg
2021-06-11 14:47 ` Chris Chiu
2021-08-13 8:26 ` Johannes Berg [this message]
2021-06-03 12:06 ` [PATCH v2 2/2] rtl8xxxu: Fix ampdu_action to get block ack session work chris.chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64b3313ec8a15229e75a29fac2fb5ba1491a2191.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Jes.Sorensen@gmail.com \
--cc=chris.chiu@canonical.com \
--cc=code@reto-schneider.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).