From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 977C03D47B2; Mon, 4 May 2026 12:43:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777898605; cv=none; b=WKgcJYlaATDbg6DaO/5XFMd9s6CfqhaJG15snnvFtfZMd52Py2vH8sLyQ5qztJ6wwwqnkx02hp3zrv4HhhuY9cblp1nmfP+74xjPdT9o46o7VGZLS/wt0uA45bA7v+6S+koXC8f0yTbjymdDEkz39O5ujz1wIMWHPmZRcd6TZqk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777898605; c=relaxed/simple; bh=LtuSCMu6dVDP8H3xYJPu5UCHu9oQhiVtrJaeCKFjKm4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ozq4U4SUWycFDFysAwvn8LCWTlYiZ3Bw+s/C9WAI+sA8tLl83UhVjqKHzuqc2uiE9l+IU4s0ROnFdGH4q71SG9SpA7RIl0O3r2R9IMo1RDJ2hxRjg5WJBAIcL+f5wVCHITPPDRk3Q4xPIxLcZiLtvayvqTXtv4E0SEFJEJkr964= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=MWni85lC; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="MWni85lC" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=1PMEvjlLQCF+IhJSDR+OfV1rOuww5+zhdmbObo+aXic=; b=MWni85lCQoXDMVP6bhjc2GczaN d2l5A5HEaNUgy12XQ4iQZtIe76OLfLdlkr+3UkGGsN91//fZs9i34a7a6W2d0B4l5DUg4Jj0gzZuE E8fkLl9+/Q/NH8aebCYfcaS4GPk+jTY4AS0wwKnvqR+S4pMzK5PXQlXYyPzY2UVvNpjA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wJsdl-001GDe-KX; Mon, 04 May 2026 14:43:13 +0200 Date: Mon, 4 May 2026 14:43:13 +0200 From: Andrew Lunn To: Rosen Penev Cc: netdev@vger.kernel.org, Felix Fietkau , Lorenzo Bianconi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , "open list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Subject: Re: [PATCH net-next] net: mtk_star_emac: use of_get_ethdev_address Message-ID: <64c2b026-88b1-4560-8763-9f6696d854a5@lunn.ch> References: <20260504031019.607682-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260504031019.607682-1-rosenp@gmail.com> On Sun, May 03, 2026 at 08:10:19PM -0700, Rosen Penev wrote: > The platform_ variant calls arch_get_platform_mac_address which is only > implemented under SPARC. platform_get_ethdev_address() calls eth_platform_get_mac_address(). int eth_platform_get_mac_address(struct device *dev, u8 *mac_addr) { unsigned char *addr; int ret; ret = of_get_mac_address(dev->of_node, mac_addr); if (!ret) return 0; addr = arch_get_platform_mac_address(); if (!addr) return -ENODEV; ether_addr_copy(mac_addr, addr); return 0; } > Switch to the of variant as of functions are used in the surrounding > code and to get EPROBE_DEFER support in order to handle NVMEM MAC > address specifications. So there is a call to of_get_mac_address(). And it calls arch_get_platform_mac_address() as well. If you only call of_get_mac_address(), don't you break SPARC? If EPROBE_DEFER is what you are trying to get, please change eth_platform_get_mac_address() to actually return it, not break SPARC. Andrew --- pw-bot: cr