From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Gustavo Luiz Duarte <gustavold@gmail.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
David Ahern <dsahern@kernel.org>,
Breno Leitao <leitao@debian.org>,
Willem de Bruijn <willemb@google.com>,
linux-kernel@vger.kernel.org,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Subject: RE: [PATCH] net: ipmr: Call ipmr_ioctl() directly from ipmr_sk_ioctl()
Date: Mon, 31 Jul 2023 14:27:06 -0400 [thread overview]
Message-ID: <64c7fcfa3d428_17de01294e8@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <20230731145713.178509-1-gustavold@gmail.com>
Gustavo Luiz Duarte wrote:
> Call ipmr_ioctl()/ip6mr_ioctl() directly from ipmr_sk_ioctl()/ip6mr_sk_ioctl()
> and avoid sk_prot->ioctl function pointer indirection.
>
> Also, delete the sock_ioctl_inout() helper as it is no longer needed.
>
> Signed-off-by: Gustavo Luiz Duarte <gustavold@gmail.com>
> Suggested-by: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> ---
> include/linux/mroute6.h | 33 ++++++++++++++++++++++++++-------
> include/net/sock.h | 2 --
> net/core/sock.c | 20 --------------------
> net/ipv4/ipmr.c | 33 ++++++++++++++++++++++++++-------
> 4 files changed, 52 insertions(+), 36 deletions(-)
The helper function does save some LoC, it seems.
My comment came during review of the series. Now that that is in,
fine to leave as is, imho.
next prev parent reply other threads:[~2023-07-31 18:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 14:57 [PATCH] net: ipmr: Call ipmr_ioctl() directly from ipmr_sk_ioctl() Gustavo Luiz Duarte
2023-07-31 18:27 ` Willem de Bruijn [this message]
2023-08-09 3:26 ` kernel test robot
2023-08-09 22:25 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64c7fcfa3d428_17de01294e8@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gustavold@gmail.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).