netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Eric Dumazet <edumazet@google.com>,
	 "David S . Miller" <davem@davemloft.net>,
	 Jakub Kicinski <kuba@kernel.org>,
	 Paolo Abeni <pabeni@redhat.com>
Cc: Willem de Bruijn <willemb@google.com>,
	 Tahsin Erdogan <trdgn@amazon.com>,
	 netdev@vger.kernel.org,  eric.dumazet@gmail.com,
	 Eric Dumazet <edumazet@google.com>
Subject: RE: [PATCH v2 net-next 0/4] net: extend alloc_skb_with_frags() max size
Date: Tue, 01 Aug 2023 17:05:01 -0400	[thread overview]
Message-ID: <64c9737d36571_1d4d6f294b@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <20230801205254.400094-1-edumazet@google.com>

Eric Dumazet wrote:
> alloc_skb_with_frags(), while being able to use high order allocations,
> limits the payload size to PAGE_SIZE * MAX_SKB_FRAGS
> 
> Reviewing Tahsin Erdogan patch [1], it was clear to me we need
> to remove this limitation.
> 
> [1] https://lore.kernel.org/netdev/20230731230736.109216-1-trdgn@amazon.com/
> 
> v2: Addressed Willem feedback on 1st patch.
> 
> Eric Dumazet (4):
>   net: allow alloc_skb_with_frags() to allocate bigger packets
>   net: tun: change tun_alloc_skb() to allow bigger paged allocations
>   net/packet: change packet_alloc_skb() to allow bigger paged
>     allocations
>   net: tap: change tap_alloc_skb() to allow bigger paged allocations
> 
>  drivers/net/tap.c      |  4 ++-
>  drivers/net/tun.c      |  4 ++-
>  net/core/skbuff.c      | 56 +++++++++++++++++++-----------------------
>  net/packet/af_packet.c |  4 ++-
>  4 files changed, 34 insertions(+), 34 deletions(-)

For the series:

Reviewed-by: Willem de Bruijn <willemb@google.com>

Thanks Eric


  parent reply	other threads:[~2023-08-01 21:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-01 20:52 [PATCH v2 net-next 0/4] net: extend alloc_skb_with_frags() max size Eric Dumazet
2023-08-01 20:52 ` [PATCH v2 net-next 1/4] net: allow alloc_skb_with_frags() to allocate bigger packets Eric Dumazet
2023-08-01 20:52 ` [PATCH v2 net-next 2/4] net: tun: change tun_alloc_skb() to allow bigger paged allocations Eric Dumazet
2023-08-01 20:52 ` [PATCH v2 net-next 3/4] net/packet: change packet_alloc_skb() " Eric Dumazet
2023-08-01 20:52 ` [PATCH v2 net-next 4/4] net: tap: change tap_alloc_skb() " Eric Dumazet
2023-08-01 21:05 ` Willem de Bruijn [this message]
2023-08-03  1:50 ` [PATCH v2 net-next 0/4] net: extend alloc_skb_with_frags() max size patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64c9737d36571_1d4d6f294b@willemb.c.googlers.com.notmuch \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=trdgn@amazon.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).