netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] udp/udplite: Remove unused function declarations udp{,lite}_get_port()
@ 2023-08-05 11:00 Yue Haibing
  2023-08-05 18:35 ` Willem de Bruijn
  2023-08-07  8:00 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Yue Haibing @ 2023-08-05 11:00 UTC (permalink / raw)
  To: davem, edumazet, kuba, pabeni, kuniyu; +Cc: netdev, yuehaibing

Commit 6ba5a3c52da0 ("[UDP]: Make full use of proto.h.udp_hash innovation.")
removed these implementations but leave declarations.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 include/net/udp.h     | 3 ---
 include/net/udplite.h | 2 --
 2 files changed, 5 deletions(-)

diff --git a/include/net/udp.h b/include/net/udp.h
index 5a8421cd9083..488a6d2babcc 100644
--- a/include/net/udp.h
+++ b/include/net/udp.h
@@ -273,9 +273,6 @@ static inline struct sk_buff *skb_recv_udp(struct sock *sk, unsigned int flags,
 
 int udp_v4_early_demux(struct sk_buff *skb);
 bool udp_sk_rx_dst_set(struct sock *sk, struct dst_entry *dst);
-int udp_get_port(struct sock *sk, unsigned short snum,
-		 int (*saddr_cmp)(const struct sock *,
-				  const struct sock *));
 int udp_err(struct sk_buff *, u32);
 int udp_abort(struct sock *sk, int err);
 int udp_sendmsg(struct sock *sk, struct msghdr *msg, size_t len);
diff --git a/include/net/udplite.h b/include/net/udplite.h
index 299c14ce2bb9..bd33ff2b8f42 100644
--- a/include/net/udplite.h
+++ b/include/net/udplite.h
@@ -81,6 +81,4 @@ static inline __wsum udplite_csum(struct sk_buff *skb)
 }
 
 void udplite4_register(void);
-int udplite_get_port(struct sock *sk, unsigned short snum,
-		     int (*scmp)(const struct sock *, const struct sock *));
 #endif	/* _UDPLITE_H */
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH net-next] udp/udplite: Remove unused function declarations udp{,lite}_get_port()
  2023-08-05 11:00 [PATCH net-next] udp/udplite: Remove unused function declarations udp{,lite}_get_port() Yue Haibing
@ 2023-08-05 18:35 ` Willem de Bruijn
  2023-08-07  8:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Willem de Bruijn @ 2023-08-05 18:35 UTC (permalink / raw)
  To: Yue Haibing, davem, edumazet, kuba, pabeni, kuniyu; +Cc: netdev, yuehaibing

Yue Haibing wrote:
> Commit 6ba5a3c52da0 ("[UDP]: Make full use of proto.h.udp_hash innovation.")
> removed these implementations but leave declarations.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Reviewed-by: Willem de Bruijn <willemb@google.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] udp/udplite: Remove unused function declarations udp{,lite}_get_port()
  2023-08-05 11:00 [PATCH net-next] udp/udplite: Remove unused function declarations udp{,lite}_get_port() Yue Haibing
  2023-08-05 18:35 ` Willem de Bruijn
@ 2023-08-07  8:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-08-07  8:00 UTC (permalink / raw)
  To: Yue Haibing; +Cc: davem, edumazet, kuba, pabeni, kuniyu, netdev

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Sat, 5 Aug 2023 19:00:09 +0800 you wrote:
> Commit 6ba5a3c52da0 ("[UDP]: Make full use of proto.h.udp_hash innovation.")
> removed these implementations but leave declarations.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>  include/net/udp.h     | 3 ---
>  include/net/udplite.h | 2 --
>  2 files changed, 5 deletions(-)

Here is the summary with links:
  - [net-next] udp/udplite: Remove unused function declarations udp{,lite}_get_port()
    https://git.kernel.org/netdev/net-next/c/cc97777c80fd

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-08-07  8:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-05 11:00 [PATCH net-next] udp/udplite: Remove unused function declarations udp{,lite}_get_port() Yue Haibing
2023-08-05 18:35 ` Willem de Bruijn
2023-08-07  8:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).