From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Mahmoud Maatuq <mahmoudmatook.mm@gmail.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kuba@kernel.org, netdev@vger.kernel.org,
willemdebruijn.kernel@gmail.com, davem@davemloft.net,
pabeni@redhat.com, edumazet@google.com, shuah@kernel.org
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
Mahmoud Maatuq <mahmoudmatook.mm@gmail.com>
Subject: Re: [PATCH 2/2] selftests/net: replace ternary operator with min()/max()
Date: Sun, 20 Aug 2023 11:10:33 -0400 [thread overview]
Message-ID: <64e22ce99cfa6_35801629446@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <20230819195005.99387-3-mahmoudmatook.mm@gmail.com>
Mahmoud Maatuq wrote:
> Fix the following coccicheck warning:
> tools/testing/selftests/net/udpgso_bench_tx.c:297:18-19: WARNING opportunity for min()
> tools/testing/selftests/net/udpgso_bench_tx.c:354:27-28: WARNING opportunity for min()
> tools/testing/selftests/net/so_txtime.c:129:24-26: WARNING opportunity for max()
> tools/testing/selftests/net/so_txtime.c:96:30-31: WARNING opportunity for max()
>
> Signed-off-by: Mahmoud Maatuq <mahmoudmatook.mm@gmail.com>
> ---
> tools/testing/selftests/net/Makefile | 2 ++
> tools/testing/selftests/net/so_txtime.c | 7 ++++---
> tools/testing/selftests/net/udpgso_bench_tx.c | 6 +++---
> 3 files changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> index 7f3ab2a93ed6..a06cc25489f9 100644
> --- a/tools/testing/selftests/net/Makefile
> +++ b/tools/testing/selftests/net/Makefile
> @@ -3,6 +3,8 @@
>
> CFLAGS = -Wall -Wl,--no-as-needed -O2 -g
> CFLAGS += -I../../../../usr/include/ $(KHDR_INCLUDES)
> +# Additional include paths needed by kselftest.h
> +CFLAGS += -I../
Why this, instead of the existing include with relative path?
next prev parent reply other threads:[~2023-08-20 15:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-19 19:50 [PATCH 0/2] selftests: Introduce common min()/max() and apply them in net tests Mahmoud Maatuq
2023-08-19 19:50 ` [PATCH 1/2] selftests: Provide local define of min() and max() Mahmoud Maatuq
2023-08-20 15:15 ` Willem de Bruijn
2023-08-21 13:04 ` David Laight
2023-08-22 14:34 ` Willem de Bruijn
2023-08-22 14:48 ` David Laight
2023-08-23 19:35 ` Mahmoud Matook
2023-08-24 8:53 ` David Laight
2023-08-19 19:50 ` [PATCH 2/2] selftests/net: replace ternary operator with min()/max() Mahmoud Maatuq
2023-08-20 15:10 ` Willem de Bruijn [this message]
2023-08-23 19:40 ` Mahmoud Matook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64e22ce99cfa6_35801629446@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mahmoudmatook.mm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).