From: David Ahern <dsahern@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Ido Schimmel <idosch@nvidia.com>, Jiri Pirko <jiri@resnulli.us>
Cc: Breno Leitao <leitao@debian.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH] team: avoid NETDEV_CHANGEMTU event when unregistering slave
Date: Sun, 25 Jan 2026 19:35:59 -0700 [thread overview]
Message-ID: <64f626f4-5432-4335-b6aa-af74b49b4a5e@kernel.org> (raw)
In-Reply-To: <ece4365f-906c-44e2-80c9-ab73f91f7fb5@I-love.SAKURA.ne.jp>
On 1/25/26 7:35 AM, Tetsuo Handa wrote:
> syzbot is reporting
> @@ -1330,7 +1330,13 @@ static int team_port_del(struct team *team, struct net_device *port_dev)
> __team_port_change_port_removed(port);
>
> team_port_set_orig_dev_addr(port);
> - dev_set_mtu(port_dev, port->orig.mtu);
> + if (unregister) {
> + netdev_lock_ops(port_dev);
> + __netif_set_mtu(port_dev, port->orig.mtu);
> + netdev_unlock_ops(port_dev);
> + } else {
> + dev_set_mtu(port_dev, port->orig.mtu);
> + }
> kfree_rcu(port, rcu);
> netdev_info(dev, "Port device %s removed\n", portname);
> netdev_compute_master_upper_features(team->dev, true);
same logic as bonding, so a netdev based helper that both drivers can use?
next prev parent reply other threads:[~2026-01-26 2:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-25 5:11 [PATCH] ipv4: don't call inetdev_init() if device is no longer registered Tetsuo Handa
2026-01-25 8:58 ` Ido Schimmel
2026-01-25 11:21 ` Tetsuo Handa
2026-01-25 12:15 ` Ido Schimmel
2026-01-25 14:35 ` [PATCH] team: avoid NETDEV_CHANGEMTU event when unregistering slave Tetsuo Handa
2026-01-26 2:35 ` David Ahern [this message]
2026-01-26 11:08 ` Tetsuo Handa
2026-01-27 7:38 ` Jiri Pirko
2026-01-27 7:42 ` Ido Schimmel
2026-01-27 12:36 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64f626f4-5432-4335-b6aa-af74b49b4a5e@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox