From: "Rémi Denis-Courmont" <remi@remlab.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org,
"Rémi Denis-Courmont" <remi.denis-courmont@nokia.com>
Subject: Re: [PATCH net-next] Phonet: use rwlock for sockets list
Date: Fri, 06 Nov 2009 14:54:38 +0100 [thread overview]
Message-ID: <65081524fbfeb975c842ebc79a8fb038@chewa.net> (raw)
In-Reply-To: <4AF42834.7010707@gmail.com>
On Fri, 06 Nov 2009 14:44:20 +0100, Eric Dumazet <eric.dumazet@gmail.com>
wrote:
> Rémi Denis-Courmont a écrit :
>> From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
>>
>> Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
>> ---
>> net/phonet/socket.c | 24 ++++++++++++------------
>> 1 files changed, 12 insertions(+), 12 deletions(-)
>
> Hmm... rwlocks are bad...
They're in many places throughout the non-IP families...
> Would you care to explain why you introduce a rwlock ?
It seems better than a spinlock, assuming that sockets are
created/destroyed more seldom than they receive packets. And then
sk_for_each_rcu does not exist. I am sure there is a good reason for that,
though I wouldn't know. I guess I should try to use RCU hlist_nulls then?
--
Rémi Denis-Courmont
next prev parent reply other threads:[~2009-11-06 13:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 13:41 [PATCH net-next] Phonet: use rwlock for sockets list Rémi Denis-Courmont
2009-11-06 13:44 ` Eric Dumazet
2009-11-06 13:54 ` Rémi Denis-Courmont [this message]
2009-11-06 14:00 ` Eric Dumazet
2009-11-06 14:29 ` Rémi Denis-Courmont
2009-11-07 2:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65081524fbfeb975c842ebc79a8fb038@chewa.net \
--to=remi@remlab.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=remi.denis-courmont@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).