From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Wahren Subject: Re: [PATCH net-next 8/8] net: qualcomm: add QCA7000 UART driver Date: Wed, 21 Sep 2016 09:49:16 +0200 Message-ID: <6516862d-9703-5a61-16f5-e363c8e370cb@i2se.com> References: <1474376544-20515-1-git-send-email-stefan.wahren@i2se.com> <1474376544-20515-9-git-send-email-stefan.wahren@i2se.com> <2EE064FD-FCC1-4559-819D-471BD000F5AF@holtmann.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , Greg Kroah-Hartman , Jiri Slaby , Network Development , LKML , Rob Herring To: Marcel Holtmann Return-path: In-Reply-To: <2EE064FD-FCC1-4559-819D-471BD000F5AF@holtmann.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi Marcel, Am 20.09.2016 um 17:32 schrieb Marcel Holtmann: > Hi Stefan, > >> This patch adds the Ethernet over UART driver for the >> Qualcomm QCA7000 HomePlug GreenPHY. >> >> Signed-off-by: Stefan Wahren >> --- >> drivers/net/ethernet/qualcomm/Kconfig | 12 + >> drivers/net/ethernet/qualcomm/Makefile | 2 + >> drivers/net/ethernet/qualcomm/qca_common.h | 6 + >> drivers/net/ethernet/qualcomm/qca_uart.c | 447 +++++++++++++++++++++++++++++ >> include/uapi/linux/tty.h | 1 + >> 5 files changed, 468 insertions(+) >> create mode 100644 drivers/net/ethernet/qualcomm/qca_uart.c >> >> diff --git a/drivers/net/ethernet/qualcomm/Kconfig b/drivers/net/ethernet/qualcomm/Kconfig >> index 0d33728..0ede46e 100644 >> --- a/drivers/net/ethernet/qualcomm/Kconfig >> +++ b/drivers/net/ethernet/qualcomm/Kconfig >> @@ -30,6 +30,18 @@ config QCA7000_SPI >> To compile this driver as a module, choose M here. The module >> will be called qcaspi. >> >> +config QCA7000_UART >> + tristate "Qualcomm Atheros QCA7000 UART support" >> + select QCA7000 >> + depends on TTY >> + ---help--- >> + This UART protocol driver supports the Qualcomm Atheros QCA7000. >> + The driver implements the tty line discipline N_QCA7K and supports >> + only one netdevice. >> + >> + To compile this driver as a module, choose M here. The module >> + will be called qcauart. >> + > this seems to be another candidate for having a proper UART or serial bus. Instead of adding one line discipline after another, I think we need to get quickly to having an enumerable bus here. i noticed Rob's thread about the UART slave device bus and i like the idea. Stefan > > Regards > > Marcel >