From: David Howells <dhowells@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: dhowells@redhat.com, paul.moore@hp.com, netdev@vger.kernel.org
Subject: Re: [PATCH] NETLABEL: Fix an RCU warning
Date: Thu, 25 Mar 2010 11:37:24 +0000 [thread overview]
Message-ID: <6522.1269517044@redhat.com> (raw)
In-Reply-To: <1269516484.3626.21.camel@edumazet-laptop>
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Sorry this is not the right fix.
>
> Fix is to change the dereference check to take into account the lock
> owned here.
Then the comments on netlbl_unlhsh_hash(), netlbl_unlhsh_search_iface(),
netlbl_unlhsh_search_iface_def() and netlbl_unlhsh_add_iface() are all wrong,
for all of them say:
* The caller is responsible for calling the rcu_read_[un]lock()
* functions.
Furthermore, netlabel_unlhsh_add() and netlabel_unlhsh_remove() _do_ wrap the
calls to those functions in rcu_read_lock'd sections.
David
next prev parent reply other threads:[~2010-03-25 11:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 11:06 [PATCH] NETLABEL: Fix an RCU warning David Howells
2010-03-25 11:28 ` Eric Dumazet
2010-03-25 11:37 ` David Howells [this message]
2010-03-25 13:32 ` Eric Dumazet
2010-03-25 14:10 ` Paul Moore
2010-03-29 15:24 ` Paul E. McKenney
2010-03-29 15:30 ` Paul Moore
2010-03-29 15:58 ` Paul E. McKenney
2010-03-29 20:05 ` Paul Moore
2010-03-29 20:19 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6522.1269517044@redhat.com \
--to=dhowells@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).