From: David Ahern <dsahern@gmail.com>
To: Serhey Popovych <serhe.popovych@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next 4/6] iptunnel/ip6tunnel: Code cleanups
Date: Tue, 6 Feb 2018 19:16:13 -0700 [thread overview]
Message-ID: <652a40b7-6828-bb7b-ec08-0fa31ec17f06@gmail.com> (raw)
In-Reply-To: <1517577055-23788-5-git-send-email-serhe.popovych@gmail.com>
On 2/2/18 6:10 AM, Serhey Popovych wrote:
> @@ -414,15 +428,18 @@ static int do_tunnels_list(struct ip_tunnel_parm *p)
> fprintf(stderr, "Failed to get type of \"%s\"\n", name);
> continue;
> }
> - if (type != ARPHRD_TUNNEL && type != ARPHRD_IPGRE && type != ARPHRD_SIT)
> + switch (type) {
> + case ARPHRD_TUNNEL:
> + case ARPHRD_IPGRE:
> + case ARPHRD_SIT:
> + break;
> + default:
> continue;
> + }
> + memset(p1, 0, sizeof(p1));
Shouldn't that be &p1 for the first arg? I get a compile failure:
ip
CC iptunnel.o
CC ip6tunnel.o
iptunnel.c: In function ‘do_tunnels_list’:
iptunnel.c:439:10: error: incompatible type for argument 1 of ‘memset’
memset(p1, 0, sizeof(p1));
^~
In file included from iptunnel.c:15:0:
/usr/include/string.h:62:14: note: expected ‘void *’ but argument is of
type ‘struct ip_tunnel_parm’
extern void *memset (void *__s, int __c, size_t __n) __THROW __nonnull
((1));
^~~~~~
../config.mk:48: recipe for target 'iptunnel.o' failed
> if (tnl_get_ioctl(name, &p1))
> continue;
> - if ((p->link && p1.link != p->link) ||
> - (p->name[0] && strcmp(p1.name, p->name)) ||
> - (p->iph.daddr && p1.iph.daddr != p->iph.daddr) ||
> - (p->iph.saddr && p1.iph.saddr != p->iph.saddr) ||
> - (p->i_key && p1.i_key != p->i_key))
> + if (!ip_tunnel_parm_match(p, &p1))
> continue;
> print_tunnel(&p1);
> if (show_stats) {
next prev parent reply other threads:[~2018-02-07 2:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 13:10 [PATCH iproute2-next 0/6] ip: Use netlink to walk through network device list Serhey Popovych
2018-02-02 13:10 ` [PATCH iproute2-next 1/6] ipaddress: Unify print_link_stats() and print_link_stats64() Serhey Popovych
2018-02-02 13:10 ` [PATCH iproute2-next 2/6] ip: Introduce get_rtnl_link_stats_rta() to get link statistics Serhey Popovych
2018-02-02 13:10 ` [PATCH iproute2-next 3/6] tunnel: Split statistic getting and printing Serhey Popovych
2018-02-02 13:10 ` [PATCH iproute2-next 4/6] iptunnel/ip6tunnel: Code cleanups Serhey Popovych
2018-02-07 2:16 ` David Ahern [this message]
2018-02-07 2:19 ` David Ahern
2018-02-07 6:20 ` Serhey Popovych
2018-02-07 6:15 ` Serhey Popovych
2018-02-02 13:10 ` [PATCH iproute2-next 5/6] iptunnel/ip6tunnel: Use netlink to walk through tunnels list Serhey Popovych
2018-02-02 13:10 ` [PATCH iproute2-next 6/6] tuntap: Use netlink to walk through tuntap list Serhey Popovych
2018-02-02 13:21 ` [PATCH iproute2-next 0/6] ip: Use netlink to walk through network device list Serhey Popovych
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=652a40b7-6828-bb7b-ec08-0fa31ec17f06@gmail.com \
--to=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=serhe.popovych@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).