From: David Laight <David.Laight@ACULAB.COM>
To: 'Eric Dumazet' <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>
Cc: netdev <netdev@vger.kernel.org>,
Willem de Bruijn <willemb@google.com>,
Neal Cardwell <ncardwell@google.com>,
Yuchung Cheng <ycheng@google.com>
Subject: RE: [RFC net-next] tcp: allow larger TSO to be built under overload
Date: Tue, 8 Mar 2022 09:07:57 +0000 [thread overview]
Message-ID: <652afb8e99a34afc86bd4d850c1338e5@AcuMS.aculab.com> (raw)
In-Reply-To: <CANn89iLoWOdLQWB0PeTtbOtzkAT=cWgzy5_RXqqLchZu1GziZw@mail.gmail.com>
From: Eric Dumazet
> Sent: 08 March 2022 03:50
...
> /* Goal is to send at least one packet per ms,
> * not one big TSO packet every 100 ms.
> * This preserves ACK clocking and is consistent
> * with tcp_tso_should_defer() heuristic.
> */
> - segs = max_t(u32, bytes / mss_now, min_tso_segs);
> -
> - return segs;
> + return max_t(u32, bytes / mss_now, min_tso_segs);
> }
Which is the common side of that max_t() ?
If it is mon_tso_segs it might be worth avoiding the
divide by coding as:
return bytes > mss_now * min_tso_segs ? bytes / mss_now : min_tso_segs;
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2022-03-08 9:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 3:03 [RFC net-next] tcp: allow larger TSO to be built under overload Jakub Kicinski
2022-03-08 3:50 ` Eric Dumazet
2022-03-08 4:29 ` Jakub Kicinski
2022-03-08 9:07 ` David Laight [this message]
2022-03-08 19:53 ` Eric Dumazet
2022-03-08 22:12 ` David Laight
2022-03-08 22:26 ` Eric Dumazet
2022-03-08 22:42 ` Eric Dumazet
2022-03-09 0:18 ` Jakub Kicinski
2022-03-09 1:09 ` Eric Dumazet
2022-03-09 16:42 ` Neal Cardwell
2022-03-09 16:54 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=652afb8e99a34afc86bd4d850c1338e5@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).