From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Yan Zhai <yan@cloudflare.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Aya Levin <ayal@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>,
linux-kernel@vger.kernel.org, kernel-team@cloudflare.com,
Florian Westphal <fw@strlen.de>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Alexander H Duyck <alexander.duyck@gmail.com>
Subject: Re: [PATCH v3 net-next 2/3] ipv6: refactor ip6_finish_output for GSO handling
Date: Fri, 20 Oct 2023 15:16:16 -0400 [thread overview]
Message-ID: <6532d200c080d_28a354294e8@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <496ccff707e16e98163d2a3fbcfbc1f824fd8ec3.1697779681.git.yan@cloudflare.com>
Yan Zhai wrote:
> Separate GSO and non-GSO packets handling to make the logic cleaner. For
> GSO packets, frag_max_size check can be omitted because it is only
> useful for packets defragmented by netfilter hooks. Both local output
> and GRO logic won't produce GSO packets when defragment is needed. This
> also mirrors what IPv4 side code is doing.
>
> Suggested-by: Florian Westphal <fw@strlen.de>
> Signed-off-by: Yan Zhai <yan@cloudflare.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Thanks for splitting up the series. This change alone is subtle enough
that it benefits from standing alone. I thought it was intended to be
a NOOP, but you indeed call out the frag_max_size special case.
next prev parent reply other threads:[~2023-10-20 19:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 5:32 [PATCH v3 net-next 0/3] ipv6: avoid atomic fragment on GSO output Yan Zhai
2023-10-20 5:32 ` [PATCH v3 net-next 1/3] ipv6: remove dst_allfrag test on ipv6 output Yan Zhai
2023-10-20 6:06 ` Eric Dumazet
2023-10-20 6:39 ` Yan Zhai
2023-10-20 9:23 ` Eric Dumazet
2023-10-20 10:00 ` Florian Westphal
2023-10-20 13:57 ` Yan Zhai
2023-10-20 5:32 ` [PATCH v3 net-next 2/3] ipv6: refactor ip6_finish_output for GSO handling Yan Zhai
2023-10-20 19:16 ` Willem de Bruijn [this message]
2023-10-20 5:32 ` [PATCH v3 net-next 3/3] ipv6: avoid atomic fragment on GSO packets Yan Zhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6532d200c080d_28a354294e8@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=alexander.duyck@gmail.com \
--cc=ayal@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
--cc=yan@cloudflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).