* [PATCH net-next] net_sched: sch_fq: fastpath needs to take care of sk->sk_pacing_status
@ 2023-10-20 20:12 Eric Dumazet
2023-10-20 20:32 ` Willem de Bruijn
2023-10-23 23:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Eric Dumazet @ 2023-10-20 20:12 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, Paolo Abeni
Cc: netdev, eric.dumazet, Eric Dumazet
If packets of a TCP flows take the fast path, we need to make sure
sk->sk_pacing_status is set to SK_PACING_FQ otherwise TCP might
fallback to internal pacing, which is not optimal.
Fixes: 076433bd78d7 ("net_sched: sch_fq: add fast path for mostly idle qdisc")
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
net/sched/sch_fq.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/net/sched/sch_fq.c b/net/sched/sch_fq.c
index f6fd0de293e583ad6ba505060ce12c74f349a1a2..bf9d00518a60853b27910c47738509c09d53bf19 100644
--- a/net/sched/sch_fq.c
+++ b/net/sched/sch_fq.c
@@ -383,6 +383,10 @@ static struct fq_flow *fq_classify(struct Qdisc *sch, struct sk_buff *skb,
if (fq_fastpath_check(sch, skb, now)) {
q->internal.stat_fastpath_packets++;
+ if (skb->sk == sk && q->rate_enable &&
+ READ_ONCE(sk->sk_pacing_status) != SK_PACING_FQ)
+ smp_store_release(&sk->sk_pacing_status,
+ SK_PACING_FQ);
return &q->internal;
}
--
2.42.0.655.g421f12c284-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net_sched: sch_fq: fastpath needs to take care of sk->sk_pacing_status
2023-10-20 20:12 [PATCH net-next] net_sched: sch_fq: fastpath needs to take care of sk->sk_pacing_status Eric Dumazet
@ 2023-10-20 20:32 ` Willem de Bruijn
2023-10-23 23:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Willem de Bruijn @ 2023-10-20 20:32 UTC (permalink / raw)
To: Eric Dumazet, David S . Miller, Jakub Kicinski, Paolo Abeni
Cc: netdev, eric.dumazet, Eric Dumazet
Eric Dumazet wrote:
> If packets of a TCP flows take the fast path, we need to make sure
> sk->sk_pacing_status is set to SK_PACING_FQ otherwise TCP might
> fallback to internal pacing, which is not optimal.
>
> Fixes: 076433bd78d7 ("net_sched: sch_fq: add fast path for mostly idle qdisc")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net_sched: sch_fq: fastpath needs to take care of sk->sk_pacing_status
2023-10-20 20:12 [PATCH net-next] net_sched: sch_fq: fastpath needs to take care of sk->sk_pacing_status Eric Dumazet
2023-10-20 20:32 ` Willem de Bruijn
@ 2023-10-23 23:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-10-23 23:00 UTC (permalink / raw)
To: Eric Dumazet; +Cc: davem, kuba, pabeni, netdev, eric.dumazet
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 20 Oct 2023 20:12:54 +0000 you wrote:
> If packets of a TCP flows take the fast path, we need to make sure
> sk->sk_pacing_status is set to SK_PACING_FQ otherwise TCP might
> fallback to internal pacing, which is not optimal.
>
> Fixes: 076433bd78d7 ("net_sched: sch_fq: add fast path for mostly idle qdisc")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
>
> [...]
Here is the summary with links:
- [net-next] net_sched: sch_fq: fastpath needs to take care of sk->sk_pacing_status
https://git.kernel.org/netdev/net-next/c/81a416985698
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-23 23:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-20 20:12 [PATCH net-next] net_sched: sch_fq: fastpath needs to take care of sk->sk_pacing_status Eric Dumazet
2023-10-20 20:32 ` Willem de Bruijn
2023-10-23 23:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).