From: "Andreas Färber" <afaerber@suse.de>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-lpwan@lists.infradead.org, linux-wpan@vger.kernel.org,
Alexander Aring <alex.aring@gmail.com>,
Stefan Schmidt <stefan@datenfreihafen.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [RFC net-next] net: Z-Wave driver prototype
Date: Sun, 20 Jan 2019 21:26:08 +0100 [thread overview]
Message-ID: <653e10b5-ff5f-dafc-6a4f-1569883fb68b@suse.de> (raw)
In-Reply-To: <5f5aa12c-604d-ca10-1873-f5f2bbe3d266@infradead.org>
Hi,
Am 20.01.19 um 19:56 schrieb Randy Dunlap:
> On 1/20/19 10:33 AM, Andreas Färber wrote:
>> Tested as external kernel module, so Kconfig/Makefile integration missing.
[...]
>> diff --git a/drivers/net/zwave/Makefile b/drivers/net/zwave/Makefile
>> new file mode 100644
>> index 000000000000..1a4171308c79
>> --- /dev/null
>> +++ b/drivers/net/zwave/Makefile
>> @@ -0,0 +1 @@
>> +obj-m += zwave.o
>
> This will need a Kconfig file and a symbol so that the Makefile
> will not always build the zwave module.
Well, as I noted in the commit message you cut off, this Makefile is not
included from drivers/net/. So it should actually not get built at all,
unless you build it explicitly as module:
$ make -C /lib/modules/`uname -r`/build M=$PWD/drivers/net/zwave
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/kbuild/modules.txt?id=HEAD
This RFC is nowhere near merging, so there's no point in bike-shedding
about Kconfig help texts. The Kconfig/Makefile integration depends on
the alternatives outlined in the commit message of what to make of this.
Right now it does not expose any netdev nor any other useful interfaces,
merely demonstrating that via serdev it could be handled in the kernel.
The big context here is RF ASICs vs. SDR and the layering of PHY and MAC
implementations and their user-facing (socket) interfaces. Cf. slide 24:
https://events.linuxfoundation.org/wp-content/uploads/2017/12/ELCE2018_LoRa_final_Andreas-Farber.pdf
(Z-Wave was marked in orange as not-entirely-open protocol over FSK.)
I had this Z-Wave module lying around, so I gave it a quick shot to get
a feeling for the protocol in comparison. If no one finds the RFC useful
then it can die as quickly as it came to life. :)
Cheers,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
prev parent reply other threads:[~2019-01-21 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-20 18:33 [RFC net-next] net: Z-Wave driver prototype Andreas Färber
2019-01-20 18:56 ` Randy Dunlap
2019-01-20 20:26 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=653e10b5-ff5f-dafc-6a4f-1569883fb68b@suse.de \
--to=afaerber@suse.de \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-lpwan@lists.infradead.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=stefan@datenfreihafen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).