From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6D3CC43381 for ; Wed, 20 Feb 2019 23:18:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7462A2146E for ; Wed, 20 Feb 2019 23:18:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sCfN3LU5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726311AbfBTXSw (ORCPT ); Wed, 20 Feb 2019 18:18:52 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:37525 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725804AbfBTXSv (ORCPT ); Wed, 20 Feb 2019 18:18:51 -0500 Received: by mail-pl1-f195.google.com with SMTP id q3so5686416pll.4 for ; Wed, 20 Feb 2019 15:18:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WAZ3WmApr5DGREtAg+tslNLzI4k9Ak+w+xwVV3uEjVo=; b=sCfN3LU5eWljYhFHiFInNvE8AsLl6j6GKnNZcuatgRJzQbv1bmx2NuuyQFICaJDCFe Yf+8MrwDElqhYfZH2u8xWIZHp7wXgD9WGr7Zp9A8amoi0Ii6GFd1rtAZdfUpaSnl5yav 9YCFhT+oYFdo0T83JbLcxltA/NZ+smgZg/Uxk9eu9LC+o7REMQZNJfNVw/LoPPL4Eq0x X0m4qQ+sCFvOesD49gGHwJfV9wSW+MnOjiaOIO5+zoTBxm83rmwH9JHUZGqe1KuiYyD3 2KERMXszZgmGCqG96W65IHsbvqVLopiTN3e1sYTri8GkjpYtCPmwVp6qm9E5ZQpHh/ry rzTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=WAZ3WmApr5DGREtAg+tslNLzI4k9Ak+w+xwVV3uEjVo=; b=WQb0YZjgkoYj5tjVPjsAwLcQGudTRPwRhQYQ252naKPnmI+FLf3cN2YxFmU61UwwDG bDxJh5yzzNNgtit5p4bgrC7D/DmIUTRQsP7wDtaWAuoo4N3knU3Vr4uKEBj2DB6pju/l Ho4D+YH9IfNYxwDNrNTgnaeBai/7sibt0NfalxlOJSb2ATJcwxZuSsSJgCROY7GHMsvG NRT+X1XzNTJLxV1dJd+iXKKVvK3/nzajWBhi1NMqOL95r93sBQEdgDDNZHRIP7QsffNe b7aCJT3QOCNEm4X1hcDJqQ21YT1uz+OodVrEX66uDTvCKON3jg5le4eBcodLuyRHTz9n 9E2Q== X-Gm-Message-State: AHQUAuanwBRENO0TdwT3kcivijHyQQeDjoNRR8c+LdYnXREoPtRDN79k FJsj53/ATNWOAK8NLVl0WUiX5u10 X-Google-Smtp-Source: AHgI3IbLkE0d6eDgUAlMmQFJ9ai1GFKzEwI7kggSYFqFYZt0vwZb5SX3S0xvsdNkFHUXj4PQdR0asg== X-Received: by 2002:a17:902:2bc9:: with SMTP id l67mr39587409plb.241.1550704730603; Wed, 20 Feb 2019 15:18:50 -0800 (PST) Received: from [10.67.49.97] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id k1sm23439542pgq.45.2019.02.20.15.18.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Feb 2019 15:18:49 -0800 (PST) Subject: Re: [PATCH net-next v4 1/3] net: dsa: add support for bridge flags To: Russell King , Andrew Lunn , Vivien Didelot Cc: Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org References: <20190220205525.nji63ntsthxbus4l@shell.armlinux.org.uk> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <6542d026-5c68-56fe-a0c5-47f7a1e2f0fa@gmail.com> Date: Wed, 20 Feb 2019 15:18:44 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/20/19 12:55 PM, Russell King wrote: > The Linux bridge implementation allows various properties of the bridge > to be controlled, such as flooding unknown unicast and multicast frames. > This patch adds the necessary DSA infrastructure to allow the Linux > bridge support to control these properties for DSA switches. > > Reviewed-by: Vivien Didelot > Signed-off-by: Russell King > --- > include/net/dsa.h | 2 ++ > net/dsa/dsa_priv.h | 2 ++ > net/dsa/port.c | 17 +++++++++++++++++ > net/dsa/slave.c | 6 ++++++ > 4 files changed, 27 insertions(+) > > diff --git a/include/net/dsa.h b/include/net/dsa.h > index 7f2a668ef2cc..2c2c10812814 100644 > --- a/include/net/dsa.h > +++ b/include/net/dsa.h > @@ -400,6 +400,8 @@ struct dsa_switch_ops { > void (*port_stp_state_set)(struct dsa_switch *ds, int port, > u8 state); > void (*port_fast_age)(struct dsa_switch *ds, int port); > + int (*port_egress_floods)(struct dsa_switch *ds, int port, > + bool unicast, bool multicast); > > /* > * VLAN support > diff --git a/net/dsa/dsa_priv.h b/net/dsa/dsa_priv.h > index 1f4972dab9f2..f4f99ec29f5d 100644 > --- a/net/dsa/dsa_priv.h > +++ b/net/dsa/dsa_priv.h > @@ -160,6 +160,8 @@ int dsa_port_mdb_add(const struct dsa_port *dp, > struct switchdev_trans *trans); > int dsa_port_mdb_del(const struct dsa_port *dp, > const struct switchdev_obj_port_mdb *mdb); > +int dsa_port_bridge_flags(const struct dsa_port *dp, unsigned long flags, > + struct switchdev_trans *trans); > int dsa_port_vlan_add(struct dsa_port *dp, > const struct switchdev_obj_port_vlan *vlan, > struct switchdev_trans *trans); > diff --git a/net/dsa/port.c b/net/dsa/port.c > index 2d7e01b23572..6df29bddf37e 100644 > --- a/net/dsa/port.c > +++ b/net/dsa/port.c > @@ -177,6 +177,23 @@ int dsa_port_ageing_time(struct dsa_port *dp, clock_t ageing_clock, > return dsa_port_notify(dp, DSA_NOTIFIER_AGEING_TIME, &info); > } > > +int dsa_port_bridge_flags(const struct dsa_port *dp, unsigned long flags, > + struct switchdev_trans *trans) > +{ > + struct dsa_switch *ds = dp->ds; > + int port = dp->index; > + int err = 0; > + > + if (switchdev_trans_ph_prepare(trans)) > + return 0; > + > + if (ds->ops->port_egress_floods) > + err = ds->ops->port_egress_floods(ds, port, flags & BR_FLOOD, > + flags & BR_MCAST_FLOOD); > + > + return err; > +} > + > int dsa_port_fdb_add(struct dsa_port *dp, const unsigned char *addr, > u16 vid) > { > diff --git a/net/dsa/slave.c b/net/dsa/slave.c > index 2e5e7c04821b..f99161c3b1ea 100644 > --- a/net/dsa/slave.c > +++ b/net/dsa/slave.c > @@ -295,6 +295,9 @@ static int dsa_slave_port_attr_set(struct net_device *dev, > case SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME: > ret = dsa_port_ageing_time(dp, attr->u.ageing_time, trans); > break; > + case SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS: > + ret = dsa_port_bridge_flags(dp, attr->u.brport_flags, trans); > + break; > default: > ret = -EOPNOTSUPP; > break; > @@ -384,6 +387,9 @@ static int dsa_slave_port_attr_get(struct net_device *dev, > switch (attr->id) { > case SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT: > attr->u.brport_flags_support = 0; > + if (ds->ops->port_egress_floods) > + attr->u.brport_flags_support |= BR_FLOOD | > + BR_MCAST_FLOOD; There is no struct dsa_switch *ds = dp->ds that is being declared in dsa_slave_port_attr_get(): net/dsa/slave.c: In function 'dsa_slave_port_attr_get': net/dsa/slave.c:390:7: error: 'ds' undeclared (first use in this function) if (ds->ops->port_egress_floods) ^~ net/dsa/slave.c:390:7: note: each undeclared identifier is reported only once for each function it appears in scripts/Makefile.build:276: recipe for target 'net/dsa/slave.o' failed make[4]: *** [net/dsa/slave.o] Error 1 scripts/Makefile.build:492: recipe for target 'net/dsa' failed make[3]: *** [net/dsa] Error 2 make[3]: *** Waiting for unfinished jobs.... -- Florian