From: John Fastabend <john.fastabend@gmail.com>
To: Jakub Sitnicki <jakub@cloudflare.com>, Liu Jian <liujian56@huawei.com>
Cc: john.fastabend@gmail.com, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, martin.lau@linux.dev, song@kernel.org,
yonghong.song@linux.dev, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
dsahern@kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v7 0/7] add BPF_F_PERMANENT flag for sockmap skmsg redirect
Date: Fri, 03 Nov 2023 20:27:30 -0700 [thread overview]
Message-ID: <6545ba22b3cfa_3358c20839@john.notmuch> (raw)
In-Reply-To: <87bkcg1nk2.fsf@cloudflare.com>
Jakub Sitnicki wrote:
> On Sat, Oct 28, 2023 at 06:05 PM +08, Liu Jian wrote:
> > v6->v7: Rebase to latest bpf-next tree, and no changes.
> > v5->v6: Modified the description of the helper function.
> > v4->v5: Fix one refcount bug caused by patch1.
> > v3->v4: Change the two helpers's description.
> > Let BPF_F_PERMANENT takes precedence over apply/cork_bytes.
> >
> > Liu Jian (7):
> > bpf, sockmap: add BPF_F_PERMANENT flag for skmsg redirect
> > selftests/bpf: Add txmsg permanently test for sockmap
> > selftests/bpf: Add txmsg redir permanently test for sockmap
> > selftests/bpf: add skmsg verdict tests
> > selftests/bpf: add two skmsg verdict tests for BPF_F_PERMANENT flag
> > selftests/bpf: add tests for verdict skmsg to itself
> > selftests/bpf: add tests for verdict skmsg to closed socket
> >
> > include/linux/skmsg.h | 1 +
> > include/uapi/linux/bpf.h | 45 +++++--
> > net/core/skmsg.c | 6 +-
> > net/core/sock_map.c | 4 +-
> > net/ipv4/tcp_bpf.c | 12 +-
> > tools/include/uapi/linux/bpf.h | 45 +++++--
> > .../selftests/bpf/prog_tests/sockmap_basic.c | 122 ++++++++++++++++++
> > .../selftests/bpf/progs/test_sockmap_kern.h | 3 +-
> > .../bpf/progs/test_sockmap_msg_verdict.c | 25 ++++
> > tools/testing/selftests/bpf/test_sockmap.c | 41 +++++-
> > 10 files changed, 272 insertions(+), 32 deletions(-)
> > create mode 100644 tools/testing/selftests/bpf/progs/test_sockmap_msg_verdict.c
>
> I gave it one last look. For the series:
>
> Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>
Ah I assumed the reviewed-bys were just carried through. So one more time,
Reviewed-by: John Fastabend <john.fastabend@gmail.com>
prev parent reply other threads:[~2023-11-04 3:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-28 10:05 [PATCH bpf-next v7 0/7] add BPF_F_PERMANENT flag for sockmap skmsg redirect Liu Jian
2023-10-28 10:05 ` [PATCH bpf-next v7 1/7] bpf, sockmap: add BPF_F_PERMANENT flag for " Liu Jian
2023-10-28 10:05 ` [PATCH bpf-next v7 2/7] selftests/bpf: Add txmsg permanently test for sockmap Liu Jian
2023-10-28 10:05 ` [PATCH bpf-next v7 3/7] selftests/bpf: Add txmsg redir " Liu Jian
2023-10-28 10:05 ` [PATCH bpf-next v7 4/7] selftests/bpf: add skmsg verdict tests Liu Jian
2023-10-28 10:05 ` [PATCH bpf-next v7 5/7] selftests/bpf: add two skmsg verdict tests for BPF_F_PERMANENT flag Liu Jian
2023-10-28 10:05 ` [PATCH bpf-next v7 6/7] selftests/bpf: add tests for verdict skmsg to itself Liu Jian
2023-10-28 10:05 ` [PATCH bpf-next v7 7/7] selftests/bpf: add tests for verdict skmsg to closed socket Liu Jian
2023-10-30 9:04 ` Jakub Sitnicki
2023-10-30 9:12 ` [PATCH bpf-next v7 0/7] add BPF_F_PERMANENT flag for sockmap skmsg redirect Jakub Sitnicki
2023-11-04 3:27 ` John Fastabend [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6545ba22b3cfa_3358c20839@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=jakub@cloudflare.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=liujian56@huawei.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).