Re: changing usbnet's API to better deal with cdc-ncm

Ming Lei
2012-09-07T12:58:27Z

On Thu, Sep 6, 2012 at 4:13 PM, Alexey ORISHKO
<alexey.orishko@stericsson.com> wrote:
>> -----Original Message-----
>> From: Oliver Neukum [mailto:oneukum@suse.de]
>
>
>> looking at cdc-ncm it seeems to me that cdc-ncm is forced to play very
>> dirty games because usbnet doesn't have a notion about aggregating
>> packets for a single transfer.
>
> Several issues need to be improved:
> Tx path:
> 1. IP packets must be accumulated in one NTB. Currently it's done via data copy.
> Preferred way would be a possibility to have a list of skb-s in resulting frame sent down.

Looks the copy is inevitable because the buffer length of each skb in the
list is not possible to be max endpoint packet aligned, so one short packet
may terminate the current tx urb transfer.

Thanks,
--
Ming Lei